Add an argument to TpuPlatform.get_attn_backend_cls to adopt interfac…#1263
Merged
QiliangCui merged 2 commits intomainfrom Dec 8, 2025
Merged
Add an argument to TpuPlatform.get_attn_backend_cls to adopt interfac…#1263QiliangCui merged 2 commits intomainfrom
QiliangCui merged 2 commits intomainfrom
Conversation
…e change. Signed-off-by: Qiliang Cui <derrhein@gmail.com>
DescriptionStart with a short description of what the PR does and how this is a change from The rest of the description includes relevant details and context, examples:
If the change fixes a bug or a Github issue, please include a link, e.g.,: TestsPlease describe how you tested this change, and include any instructions and/or ChecklistBefore submitting this PR, please make sure:
|
jrplatin
approved these changes
Dec 8, 2025
bzgoogle
approved these changes
Dec 8, 2025
Signed-off-by: Qiliang Cui <derrhein@gmail.com>
kyuyeunk
approved these changes
Dec 8, 2025
Collaborator
kyuyeunk
left a comment
There was a problem hiding this comment.
Nit: rename this pr since it also includes fix for lora part as well.
sixiang-google
pushed a commit
that referenced
this pull request
Dec 9, 2025
#1263) Signed-off-by: Qiliang Cui <derrhein@gmail.com>
gpolovets1
pushed a commit
that referenced
this pull request
Dec 17, 2025
#1263) Signed-off-by: Qiliang Cui <derrhein@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add an argument in get_attn_backend_cls to adopt the change in vllm-project/vllm#27938.
Fix lora test broken by https://github.com/vllm-project/vllm/pull/30253/files
FIXES: b/467049790
Tests
manually test:
before the change error about
with the fix, vllm can start.
CIT
https://buildkite.com/tpu-commons/tpu-inference-ci/builds/6565
https://buildkite.com/tpu-commons/tpu-inference-ci/builds/6571
Checklist
Before submitting this PR, please make sure: