Skip to content

Fix circle reference which cause tpu_platform failed to import #1251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrjunwan-lang merged 2 commits into from
Dec 5, 2025
Merged

Fix circle reference which cause tpu_platform failed to import #1251

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f97555
Fix circle reference which cause tpu_platform failed to import
mrjunwan-lang Dec 5, 2025
b1a83ae
fix lint
mrjunwan-lang Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions tpu_inference/platforms/tpu_platform.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
from tpu_info import device
from vllm.inputs import ProcessorInputs, PromptType
from vllm.platforms.interface import Platform, PlatformEnum
from vllm.sampling_params import SamplingParams, SamplingType

from tpu_inference import envs
from tpu_inference.layers.common.sharding import ShardingConfigManager
Expand All @@ -19,12 +18,15 @@
from vllm.attention.backends.registry import AttentionBackendEnum
from vllm.config import BlockSize, ModelConfig, VllmConfig
from vllm.pooling_params import PoolingParams
from vllm.sampling_params import SamplingParams, SamplingType
else:
BlockSize = None
ModelConfig = None
VllmConfig = None
PoolingParams = None
AttentionBackendEnum = None
SamplingParams = None
SamplingType = None

logger = init_logger(__name__)

Expand Down Expand Up @@ -250,10 +252,11 @@ def supports_v1(cls, model_config: ModelConfig) -> bool:
def validate_request(
cls,
prompt: PromptType,
params: Union[SamplingParams, PoolingParams],
params: Union["SamplingParams", PoolingParams],
processed_inputs: ProcessorInputs,
) -> None:
"""Raises if this request is unsupported on this platform"""
from vllm.sampling_params import SamplingParams, SamplingType

if isinstance(params, SamplingParams):
if params.sampling_type == SamplingType.RANDOM_SEED:
Expand Down