Skip to content

Remove deprecated arg in vllm serve command#1230

Merged
jcyang43 merged 1 commit intomainfrom
dennis_remove_arg
Dec 3, 2025
Merged

Remove deprecated arg in vllm serve command#1230
jcyang43 merged 1 commit intomainfrom
dennis_remove_arg

Conversation

@meiyeh123
Copy link
Copy Markdown
Collaborator

Description

Remove --guided-decoding-backend "xgrammar" when vllm serve in mm_bench_recipe.sh

Tests

Already tested it

Checklist

Before submitting this PR, please make sure:

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have made or will make corresponding changes to any relevant documentation.

@meiyeh123 meiyeh123 requested a review from vipannalla as a code owner December 3, 2025 03:15
@meiyeh123 meiyeh123 requested review from jcyang43 and removed request for vipannalla December 3, 2025 03:15
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 3, 2025

Description

Start with a short description of what the PR does and how this is a change from
the past.

The rest of the description includes relevant details and context, examples:

  • why is this change being made,
  • the problem being solved and any relevant context,
  • why this is a good solution,
  • some information about the specific implementation,
  • shortcomings of the solution and possible future improvements.

If the change fixes a bug or a Github issue, please include a link, e.g.,:
FIXES: b/123456
FIXES: #123456

Tests

Please describe how you tested this change, and include any instructions and/or
commands to reproduce.

Checklist

Before submitting this PR, please make sure:

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have made or will make corresponding changes to any relevant documentation.

@jcyang43 jcyang43 added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 3, 2025
Signed-off-by: dennis yeh <dennis.yeh@cienet.com>
Copy link
Copy Markdown
Collaborator

@jcyang43 jcyang43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. The guided-decoding-backend arg has been deprecated by the upstream in this PR

@jcyang43 jcyang43 changed the title [CI] Remove a arg in vllm serve command Remove deprecated arg in vllm serve command Dec 3, 2025
@jcyang43 jcyang43 merged commit a4cc292 into main Dec 3, 2025
22 checks passed
@meiyeh123 meiyeh123 deleted the dennis_remove_arg branch December 3, 2025 06:02
gpolovets1 pushed a commit that referenced this pull request Dec 17, 2025
Signed-off-by: dennis yeh <dennis.yeh@cienet.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants