Skip to content

[Bugfix] Fix attention not found error#1186

Merged
jcyang43 merged 1 commit intomainfrom
fix_missing_attention
Nov 26, 2025
Merged

[Bugfix] Fix attention not found error#1186
jcyang43 merged 1 commit intomainfrom
fix_missing_attention

Conversation

@kyuyeunk
Copy link
Copy Markdown
Collaborator

Description

Address error due to vLLM change in vllm-project/vllm#29342

Tests

pytest -v -s tests/core/test_core_tpu.py

Checklist

Before submitting this PR, please make sure:

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have made or will make corresponding changes to any relevant documentation.

@github-actions
Copy link
Copy Markdown

Description

Start with a short description of what the PR does and how this is a change from
the past.

The rest of the description includes relevant details and context, examples:

  • why is this change being made,
  • the problem being solved and any relevant context,
  • why this is a good solution,
  • some information about the specific implementation,
  • shortcomings of the solution and possible future improvements.

If the change fixes a bug or a Github issue, please include a link, e.g.,:
FIXES: b/123456
FIXES: #123456

Tests

Please describe how you tested this change, and include any instructions and/or
commands to reproduce.

Checklist

Before submitting this PR, please make sure:

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have made or will make corresponding changes to any relevant documentation.

Signed-off-by: Kyuyeun Kim <kyuyeunk@google.com>
@jcyang43 jcyang43 added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 26, 2025
@kyuyeunk kyuyeunk force-pushed the fix_missing_attention branch from 83e99c4 to 95f3df1 Compare November 26, 2025 18:57
@kyuyeunk kyuyeunk requested a review from vipannalla as a code owner November 26, 2025 18:57
@jcyang43 jcyang43 merged commit b6dd6a2 into main Nov 26, 2025
23 checks passed
@kyuyeunk kyuyeunk deleted the fix_missing_attention branch November 28, 2025 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants