Skip to content

refactor: remove unused MappingPath from FactCheckModelConfig#854

Merged
Xunzhuo merged 1 commit into
mainfrom
refactor/remove-unused-fact-check-mapping-path
Dec 17, 2025
Merged

refactor: remove unused MappingPath from FactCheckModelConfig#854
Xunzhuo merged 1 commit into
mainfrom
refactor/remove-unused-fact-check-mapping-path

Conversation

@Xunzhuo
Copy link
Copy Markdown
Member

@Xunzhuo Xunzhuo commented Dec 17, 2025

Remove the unused MappingPath field from FactCheckModelConfig as the fact-check classifier loads label mappings directly from the model's config.json file, consistent with hallucination and NLI models.


  • Make sure the code changes pass the pre-commit checks.
  • Sign-off your commit by using -s when doing git commit
  • Try to classify PRs for easy understanding of the type of changes, such as [Bugfix], [Feat], and [CI].
Detailed Checklist (Click to Expand)

Thank you for your contribution to semantic-router! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.

PR Title and Classification

Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

  • [Bugfix] for bug fixes.
  • [CI/Build] for build or continuous integration improvements.
  • [Doc] for documentation fixes and improvements.
  • [Feat] for new features in the cluster (e.g., autoscaling, disaggregated prefill, etc.).
  • [Router] for changes to the vllm_router (e.g., routing algorithm, router observability, etc.).
  • [Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.

Code Quality

The PR need to meet the following code quality standards:

  • Pass all linter checks. Please use pre-commit to format your code. See README.md for installation.
  • The code need to be well-documented to ensure future contributors can easily understand the code.
  • Please include sufficient tests to ensure the change is stay correct and robust. This includes both unit tests and integration tests.

DCO and Signed-off-by

When contributing changes to this project, you must agree to the DCO. Commits must include a Signed-off-by: header which certifies agreement with the terms of the DCO.

Using -s with git commit will automatically add this header.

What to Expect for the Reviews

Remove the unused MappingPath field from FactCheckModelConfig as the fact-check classifier loads label mappings directly from the model's config.json file, consistent with hallucination and NLI models.

Signed-off-by: bitliu <bitliu@tencent.com>
@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 17, 2025

Deploy Preview for vllm-semantic-router ready!

Name Link
🔨 Latest commit 966c5d3
🔍 Latest deploy log https://app.netlify.com/projects/vllm-semantic-router/deploys/69427c63384aed0008bfcf31
😎 Deploy Preview https://deploy-preview-854--vllm-semantic-router.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Copy Markdown
Contributor

Performance Benchmark Results

Component benchmarks completed successfully.

Summary

  • Classification benchmarks: ✅
  • Decision engine benchmarks: ✅
  • Cache benchmarks: ✅

Details

See attached benchmark artifacts for detailed results and profiles.


Performance testing powered by vLLM Semantic Router

@github-actions
Copy link
Copy Markdown
Contributor

👥 vLLM Semantic Team Notification

The following members have been identified for the changed files in this PR and have been automatically assigned:

📁 bench

Owners: @yuezhu1, @Xunzhuo
Files changed:

  • bench/hallucination/config-7b.yaml
  • bench/hallucination/config.yaml

📁 config

Owners: @rootfs, @Xunzhuo
Files changed:

  • config/prompt-guard/prompt_guard.yaml
  • config/semantic-cache/config.redis.yaml
  • config/testing/config.hallucination.yaml

📁 src

Owners: @rootfs, @Xunzhuo, @wangchen615
Files changed:

  • src/semantic-router/pkg/classification/fact_check_classifier.go
  • src/semantic-router/pkg/classification/hallucination_test.go
  • src/semantic-router/pkg/config/config.go
  • src/semantic-router/pkg/config/config_test.go
  • src/semantic-router/pkg/config/helper.go

vLLM

🎉 Thanks for your contributions!

This comment was automatically generated based on the OWNER files in the repository.

@Xunzhuo Xunzhuo merged commit ad8ad74 into main Dec 17, 2025
38 checks passed
@Xunzhuo Xunzhuo deleted the refactor/remove-unused-fact-check-mapping-path branch February 27, 2026 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants