Skip to content

[Misc] fix(dashboard): proxy Jaeger /dependencies route#839

Merged
JaredforReal merged 2 commits into
vllm-project:mainfrom
samzong:dashboard-jaeger-api
Dec 15, 2025
Merged

[Misc] fix(dashboard): proxy Jaeger /dependencies route#839
JaredforReal merged 2 commits into
vllm-project:mainfrom
samzong:dashboard-jaeger-api

Conversation

@samzong
Copy link
Copy Markdown
Collaborator

@samzong samzong commented Dec 15, 2025

Add missing Jaeger proxy routes for /dependencies page and /api/dependencies API. Previously these requests fell through to the static file server and returned HTML instead of proxying to Jaeger.

FIX #xxxx (link existing issues this PR will resolve)

BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE


  • Make sure the code changes pass the pre-commit checks.
  • Sign-off your commit by using -s when doing git commit
  • Try to classify PRs for easy understanding of the type of changes, such as [Bugfix], [Feat], and [CI].
Detailed Checklist (Click to Expand)

Thank you for your contribution to semantic-router! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.

PR Title and Classification

Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

  • [Bugfix] for bug fixes.
  • [CI/Build] for build or continuous integration improvements.
  • [Doc] for documentation fixes and improvements.
  • [Feat] for new features in the cluster (e.g., autoscaling, disaggregated prefill, etc.).
  • [Router] for changes to the vllm_router (e.g., routing algorithm, router observability, etc.).
  • [Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.

Code Quality

The PR need to meet the following code quality standards:

  • Pass all linter checks. Please use pre-commit to format your code. See README.md for installation.
  • The code need to be well-documented to ensure future contributors can easily understand the code.
  • Please include sufficient tests to ensure the change is stay correct and robust. This includes both unit tests and integration tests.

DCO and Signed-off-by

When contributing changes to this project, you must agree to the DCO. Commits must include a Signed-off-by: header which certifies agreement with the terms of the DCO.

Using -s with git commit will automatically add this header.

What to Expect for the Reviews

Signed-off-by: samzong <samzong.lu@gmail.com>
@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 15, 2025

Deploy Preview for vllm-semantic-router ready!

Name Link
🔨 Latest commit f6bf31d
🔍 Latest deploy log https://app.netlify.com/projects/vllm-semantic-router/deploys/69402a3936e9a90007e2afff
😎 Deploy Preview https://deploy-preview-839--vllm-semantic-router.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 15, 2025

👥 vLLM Semantic Team Notification

The following members have been identified for the changed files in this PR and have been automatically assigned:

📁 dashboard

Owners: @JaredforReal, @Xunzhuo
Files changed:

  • dashboard/backend/router/router.go

vLLM

🎉 Thanks for your contributions!

This comment was automatically generated based on the OWNER files in the repository.

@JaredforReal
Copy link
Copy Markdown
Collaborator

JaredforReal commented Dec 15, 2025

@samzong Thanks!
/lgtm

@github-actions github-actions Bot added the lgtm label Dec 15, 2025
@JaredforReal JaredforReal merged commit f5073be into vllm-project:main Dec 15, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants