Skip to content

update: Improve Model Manager Configuration and CI Integration#830

Merged
JaredforReal merged 6 commits into
vllm-project:mainfrom
JaredforReal:update/model_manager
Dec 15, 2025
Merged

update: Improve Model Manager Configuration and CI Integration#830
JaredforReal merged 6 commits into
vllm-project:mainfrom
JaredforReal:update/model_manager

Conversation

@JaredforReal
Copy link
Copy Markdown
Collaborator

Summary

This PR enhances the Model Manager by reorganizing configuration files and improving CI workflow integration.

Changes

1. Reorganize Model Manager Configs

  • Moved model configuration files from config to model_manager
    • models.yaml → models.yaml
    • models.minimal.yaml → models.minimal.yaml
    • models.lora.yaml → models.lora.yaml
  • Updated all references in Python code and Makefiles to use new paths
  • Updated test expectations to match new configuration paths

2. Add Comprehensive Documentation

  • Added README.md with:
    • Quick start guide for CLI and programmatic usage
    • CI mode documentation
    • Configuration schema and examples
    • Complete API reference
    • Development and testing instructions

3. Improve CI Integration

  • Updated all CI workflows to use Model Manager dependencies:
    • Replaced manual pip install huggingface_hub[cli] with pip install -r src/model_manager/requirements.txt
  • Added HF_TOKEN support for gated models (e.g., embeddinggemma-300m):
    • test-and-build.yml
    • integration-test-docker.yml
    • performance-test.yml
    • performance-nightly.yml
  • Updated configuration comments to reflect HF_TOKEN availability

Benefits

  • Better organization: Model configs now grouped in dedicated directory
  • Improved documentation: Clear usage guide for contributors
  • Enhanced CI: Unified dependency management and support for gated models
  • Maintainability: Centralized model management configuration

BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE


  • Make sure the code changes pass the pre-commit checks.
  • Sign-off your commit by using -s when doing git commit
  • Try to classify PRs for easy understanding of the type of changes, such as [Bugfix], [Feat], and [CI].
Detailed Checklist (Click to Expand)

Thank you for your contribution to semantic-router! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.

PR Title and Classification

Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

  • [Bugfix] for bug fixes.
  • [CI/Build] for build or continuous integration improvements.
  • [Doc] for documentation fixes and improvements.
  • [Feat] for new features in the cluster (e.g., autoscaling, disaggregated prefill, etc.).
  • [Router] for changes to the vllm_router (e.g., routing algorithm, router observability, etc.).
  • [Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.

Code Quality

The PR need to meet the following code quality standards:

  • Pass all linter checks. Please use pre-commit to format your code. See README.md for installation.
  • The code need to be well-documented to ensure future contributors can easily understand the code.
  • Please include sufficient tests to ensure the change is stay correct and robust. This includes both unit tests and integration tests.

DCO and Signed-off-by

When contributing changes to this project, you must agree to the DCO. Commits must include a Signed-off-by: header which certifies agreement with the terms of the DCO.

Using -s with git commit will automatically add this header.

What to Expect for the Reviews

Signed-off-by: JaredforReal <w13431838023@gmail.com>
Signed-off-by: JaredforReal <w13431838023@gmail.com>
Signed-off-by: JaredforReal <w13431838023@gmail.com>
Copilot AI review requested due to automatic review settings December 14, 2025 17:31
@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 14, 2025

Deploy Preview for vllm-semantic-router ready!

Name Link
🔨 Latest commit 177a6a0
🔍 Latest deploy log https://app.netlify.com/projects/vllm-semantic-router/deploys/69402205ed2d5900086e9d61
😎 Deploy Preview https://deploy-preview-830--vllm-semantic-router.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 14, 2025

👥 vLLM Semantic Team Notification

The following members have been identified for the changed files in this PR and have been automatically assigned:

📁 Root Directory

Owners: @rootfs, @Xunzhuo
Files changed:

  • .github/workflows/integration-test-docker.yml
  • .github/workflows/performance-nightly.yml
  • .github/workflows/performance-test.yml
  • .github/workflows/test-and-build.yml

📁 config

Owners: @rootfs, @Xunzhuo
Files changed:

  • config/model_manager/models.lora.yaml
  • config/model_manager/models.minimal.yaml
  • config/model_manager/models.yaml

📁 src

Owners: @rootfs, @Xunzhuo, @wangchen615
Files changed:

  • src/model_manager/README.md
  • src/model_manager/cli.py
  • src/model_manager/requirements.txt
  • src/model_manager/tests/test_cli.py

📁 tools

Owners: @yuluo-yx, @rootfs, @Xunzhuo
Files changed:

  • tools/make/models.mk

vLLM

🎉 Thanks for your contributions!

This comment was automatically generated based on the OWNER files in the repository.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reorganizes the Model Manager configuration structure and enhances CI integration by moving configuration files to a dedicated directory, adding comprehensive documentation, and unifying dependency management across all workflows.

  • Moved model configuration files from config/ to config/model_manager/ for better organization
  • Added comprehensive README.md with usage examples, API reference, and development guidelines
  • Updated CI workflows to use centralized dependency management via requirements.txt and added HF_TOKEN support for gated models

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
tools/make/models.mk Updated comments and commands to reference new config paths in config/model_manager/
src/model_manager/cli.py Updated default config paths to point to new config/model_manager/ directory
src/model_manager/tests/test_cli.py Updated test assertions to expect new config file paths
src/model_manager/README.md Added comprehensive documentation including quick start guide, API reference, and development instructions
config/model_manager/models.yaml Updated usage comments to reflect new config path
config/model_manager/models.minimal.yaml Updated usage comments and clarified note about gated models being in the full set
config/model_manager/models.lora.yaml Updated usage comments to reflect new config path
.github/workflows/test-and-build.yml Replaced manual huggingface_hub[cli] installation with requirements.txt and added HF_TOKEN environment variable
.github/workflows/performance-test.yml Replaced manual huggingface_hub[cli] installation with requirements.txt and added HF_TOKEN environment variable
.github/workflows/performance-nightly.yml Replaced manual huggingface_hub[cli] installation with requirements.txt, added HF_TOKEN, and changed CI_MINIMAL_MODELS to false for full model set
.github/workflows/integration-test-docker.yml Replaced manual huggingface_hub[cli] installation with requirements.txt and added HF_TOKEN environment variable

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/test-and-build.yml Outdated
Comment thread .github/workflows/performance-test.yml
Comment thread .github/workflows/performance-nightly.yml
Comment thread .github/workflows/integration-test-docker.yml
Copy link
Copy Markdown
Collaborator

@samzong samzong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍 A few minor suggestions about README.md

Comment thread src/model_manager/README.md Outdated
Comment thread src/model_manager/README.md
Comment thread src/model_manager/README.md
Comment thread src/model_manager/README.md Outdated
Signed-off-by: JaredforReal <w13431838023@gmail.com>
Signed-off-by: JaredforReal <w13431838023@gmail.com>
Signed-off-by: Jared <w13431838023@gmail.com>
@JaredforReal
Copy link
Copy Markdown
Collaborator Author

@samzong PTAL, Thanks~!

@JaredforReal JaredforReal deleted the update/model_manager branch December 15, 2025 15:03
@JaredforReal JaredforReal restored the update/model_manager branch December 15, 2025 15:03
@JaredforReal JaredforReal reopened this Dec 15, 2025
Copy link
Copy Markdown
Collaborator

@samzong samzong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for u making this better.

LGTM~

@JaredforReal JaredforReal merged commit d13749e into vllm-project:main Dec 15, 2025
50 of 65 checks passed
@JaredforReal JaredforReal deleted the update/model_manager branch December 15, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants