[Feat] Feature: New Python-based Model Manager#820
Merged
JaredforReal merged 6 commits intoDec 14, 2025
Conversation
✅ Deploy Preview for vllm-semantic-router ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…tion, configuration Signed-off-by: samzong <samzong.lu@gmail.com>
…ize model configurations to YAML files. Signed-off-by: samzong <samzong.lu@gmail.com>
3b5d507 to
d335bbd
Compare
Contributor
👥 vLLM Semantic Team NotificationThe following members have been identified for the changed files in this PR and have been automatically assigned: 📁
|
Signed-off-by: samzong <samzong.lu@gmail.com>
3 tasks
rootfs
reviewed
Dec 12, 2025
rootfs
reviewed
Dec 12, 2025
rootfs
reviewed
Dec 12, 2025
Collaborator
|
@samzong this is great! thank you for making this happen! |
Signed-off-by: samzong <samzong.lu@gmail.com>
Collaborator
Author
|
@rootfs all changes is ready. |
JaredforReal
approved these changes
Dec 14, 2025
Collaborator
|
@samzong LGTM, thanks! I am doing further work, including docs and concising |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Feature: New Python-based Model Manager
This PR introduces a new Python package model_manager to replace the previous Makefile-based model download logic. It converts projects from hard-coded shell scripts to configuration-driven Python applications.
🤔 Motivation (Context)
models.mkwas becoming unwieldy with hardcoded lists of models and fragile shell logic. Adding a new model required modifying multiple conditional blocks.🚀 Changes:
src/model_manager.FIX #xxxx (link existing issues this PR will resolve)
Part of #47
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE
-swhen doinggit commit[Bugfix],[Feat], and[CI].Detailed Checklist (Click to Expand)
Thank you for your contribution to semantic-router! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]for bug fixes.[CI/Build]for build or continuous integration improvements.[Doc]for documentation fixes and improvements.[Feat]for new features in the cluster (e.g., autoscaling, disaggregated prefill, etc.).[Router]for changes to thevllm_router(e.g., routing algorithm, router observability, etc.).[Misc]for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
pre-committo format your code. SeeREADME.mdfor installation.DCO and Signed-off-by
When contributing changes to this project, you must agree to the DCO. Commits must include a
Signed-off-by:header which certifies agreement with the terms of the DCO.Using
-swithgit commitwill automatically add this header.What to Expect for the Reviews