fix: remove no needed todo and verify CI #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👥 Owner NotificationThe following owners have been identified for the changed files in this PR and have been automatically assigned: 📁
|
Signed-off-by: bitliu <[email protected]>
Xunzhuo
force-pushed
the
fix-remove-no-need
branch
from
0f5ed03 to
b1e7b2a
Compare
rootfs
approved these changes
Aug 30, 2025
This was referenced Nov 20, 2025
srini-abhiram
added a commit
to srini-abhiram/semantic-router
that referenced
this pull request
Dec 2, 2025
This commit addresses 6 critical issues identified during code review, plus build improvements for better user experience. Critical fixes: - Issue #1: PID file race condition - kill router process if PID file write fails to prevent untrackable processes - Issue vllm-project#2: Cross-platform compatibility - replace hardcoded /tmp paths with os.TempDir() and add user-specific suffixes using os.Getuid() - Issue vllm-project#3: Signal handling - add graceful shutdown for port-forward process on Ctrl+C to prevent orphaned kubectl processes - Issue vllm-project#4: HTTP timeout - add 30-second timeout to prevent hanging requests in test command - Issue vllm-project#5: Security - restrict log/PID file permissions to 0600 - Issue vllm-project#6: Input validation - enforce 10k character limit on prompts Build improvements: - Embed library path using -ldflags="-r" to eliminate need for users to manually set LD_LIBRARY_PATH when running vsr binary Files modified: - src/semantic-router/pkg/cli/deployment/deployment.go - src/semantic-router/pkg/cli/deployment/upgrade.go - src/semantic-router/cmd/vsr/commands/dashboard.go - src/semantic-router/cmd/vsr/commands/test.go - tools/make/build-run-test.mk - src/semantic-router/pkg/cli/deployment/deployment_test.go All fixes have been verified with standalone test programs. Signed-off-by: Srinivas A <[email protected]>
srini-abhiram
added a commit
to srini-abhiram/semantic-router
that referenced
this pull request
Dec 2, 2025
This commit addresses 6 critical issues identified during code review, plus build improvements for better user experience. Critical fixes: - Issue #1: PID file race condition - kill router process if PID file write fails to prevent untrackable processes - Issue vllm-project#2: Cross-platform compatibility - replace hardcoded /tmp paths with os.TempDir() and add user-specific suffixes using os.Getuid() - Issue vllm-project#3: Signal handling - add graceful shutdown for port-forward process on Ctrl+C to prevent orphaned kubectl processes - Issue vllm-project#4: HTTP timeout - add 30-second timeout to prevent hanging requests in test command - Issue vllm-project#5: Security - restrict log/PID file permissions to 0600 - Issue vllm-project#6: Input validation - enforce 10k character limit on prompts Build improvements: - Embed library path using -ldflags="-r" to eliminate need for users to manually set LD_LIBRARY_PATH when running vsr binary Files modified: - src/semantic-router/pkg/cli/deployment/deployment.go - src/semantic-router/pkg/cli/deployment/upgrade.go - src/semantic-router/cmd/vsr/commands/dashboard.go - src/semantic-router/cmd/vsr/commands/test.go - tools/make/build-run-test.mk - src/semantic-router/pkg/cli/deployment/deployment_test.go All fixes have been verified with standalone test programs. Signed-off-by: Srinivas A <[email protected]>
srini-abhiram
added a commit
to srini-abhiram/semantic-router
that referenced
this pull request
Dec 2, 2025
Add unit tests to verify all 6 critical production fixes implemented in the previous commit. Tests ensure cross-platform compatibility, security, and robustness of the VSR CLI tool. Test coverage added: - Cross-platform path handling (Issue vllm-project#2) * Absolute path validation * User-specific path generation * Temp directory usage - PID file management and security (Issues #1, vllm-project#5) * PID file race condition handling * Process termination on write failure * Restrictive 0600 file permissions * Proper cleanup on exit - HTTP client timeout (Issue vllm-project#4) * 30-second timeout prevents hanging * Fast responses unaffected * Timeout configuration validation - Input validation (Issue vllm-project#6) * 10k character limit enforcement * Boundary condition testing - Signal handling (Issue vllm-project#3) * Graceful shutdown on interrupt * Process cleanup verification * No orphaned processes All tests compile and validate the production fixes. Signed-off-by: Srinivas A <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Release Notes: Yes/No