Repository navigation
[DeepSeek] Update V4.1 Flash Blackwell TP and DEP configs - #995
Conversation
Signed-off-by: esmeetu <jasonailu87@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Code Review
This pull request updates the DeepSeek-V4.1-Flash model recipe to introduce strategy and hardware overrides for Blackwell hardware under single-node TP and DEP configurations, and updates the guide documentation accordingly. To support these overrides, the command synthesis library is updated with a new helper function, featureFieldForStrategy, which resolves feature arguments and environment variables by strategy and hardware. Feedback on the changes suggests using optional chaining defensively within this new helper function to prevent potential runtime TypeError exceptions if the feature parameter is null or undefined.
| function featureFieldForStrategy(feature, field, strategyName, hwProfile, hwProfileId) { | ||
| const strategyOverride = feature.strategy_overrides?.[strategyName]; | ||
| const strategyHardware = hardwareKeyedValue(strategyOverride?.hardware_overrides, hwProfile, hwProfileId); | ||
| const hardware = hardwareKeyedValue(feature.hardware_overrides, hwProfile, hwProfileId); | ||
| return strategyHardware?.[field] ?? strategyOverride?.[field] ?? hardware?.[field] ?? feature[field]; | ||
| } |
There was a problem hiding this comment.
To prevent potential runtime TypeError exceptions if feature is ever passed as null or undefined, use optional chaining defensively when accessing properties on the feature parameter.
| function featureFieldForStrategy(feature, field, strategyName, hwProfile, hwProfileId) { | |
| const strategyOverride = feature.strategy_overrides?.[strategyName]; | |
| const strategyHardware = hardwareKeyedValue(strategyOverride?.hardware_overrides, hwProfile, hwProfileId); | |
| const hardware = hardwareKeyedValue(feature.hardware_overrides, hwProfile, hwProfileId); | |
| return strategyHardware?.[field] ?? strategyOverride?.[field] ?? hardware?.[field] ?? feature[field]; | |
| } | |
| function featureFieldForStrategy(feature, field, strategyName, hwProfile, hwProfileId) { | |
| const strategyOverride = feature?.strategy_overrides?.[strategyName]; | |
| const strategyHardware = hardwareKeyedValue(strategyOverride?.hardware_overrides, hwProfile, hwProfileId); | |
| const hardware = hardwareKeyedValue(feature?.hardware_overrides, hwProfile, hwProfileId); | |
| return strategyHardware?.[field] ?? strategyOverride?.[field] ?? hardware?.[field] ?? feature?.[field]; | |
| } |
Signed-off-by: esmeetu <jasonailu87@gmail.com>
Update DeepSeek V4.1 Flash's Blackwell commands to select the sparse FlashInfer attention backend for TP and FlashMLA mega attention plus DeepGEMM mega MoE for DEP. Both use MXFP4 indexer KV, sparse logits, FP8 KV cache and a 128-sequence baseline; DEP also distributes Engram embeddings across DP ranks.
Preserve B300's existing TP2, Engram CPU offload, CUDA Graph capture and batch-size overrides. DEP continues to derive its size from the hardware: four ranks on GB200/GB300 trays and eight on B200/B300 nodes. Existing DSpark configuration and opt-in behavior are preserved.
Validation: