Repository navigation
[DeepSeek] Update V4 indexer cache dtype configuration - #992
Merged
Merged
Conversation
Signed-off-by: Yifan Qiao <yifanqiao@inferact.ai>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the configuration files for DeepSeek-V4 models (Flash, Flash-Vision-Exp, and Pro) by replacing the --attention_config.use_fp4_indexer_cache parameter with --attention_config.indexer_kv_dtype. The parameter values have been updated from booleans to specific data types (mxfp4 or fp8) across various hardware and strategy overrides, as well as in the documentation guides. There are no review comments to address, and I have no further feedback to provide.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
use_fp4_indexer_cachewithindexer_kv_dtypein the DSV4 Flash/Pro recipes, following InferenceX #3274:mxfp4on Blackwell, preserving RTX PRO 6000'sfp8override. Update matching guide references.Validation: recipe JSON API build and 80 generated command configurations passed.