Skip to content

Update InferenceX MI355X agentic recipes - #972

Merged
shen-shanshan merged 1 commit into
vllm-project:mainfrom
haic0:haic0/deepseek-v4-agentic-fusion-fix
Sep 14, 2026
Merged

shen-shanshan merged 1 commit into
vllm-project:mainfrom
haic0:haic0/deepseek-v4-agentic-fusion-fix

Conversation

@haic0

@haic0 haic0 commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Update the DeepSeek-V4-Pro agentic InferenceX reproduction source image to the validated ROCm nightly:
    vllm/vllm-openai-rocm:nightly-eed1f3d0c6043bd494424a22443ee198dd56f657.
  • Disable VLLM_ROCM_USE_AITER_FUSION_SHARED_EXPERTS for that nightly because the mixed MXFP4/FP8 checkpoint fails in the fused shared-expert loading path.
  • Leave the default MI355X serving configuration and separate fixed-sequence benchmark lane unchanged.

Related: SemiAnalysisAI/InferenceX#3071

Test plan

  • YAML parsing and top-level schema-order validation.
  • node scripts/build-recipes-api.mjs.
  • git diff --check.
  • Linter diagnostics for the updated YAML.

Use the validated nightly image and disable incompatible AITER shared-expert fusion in the agentic reproduction guide while leaving other MI355X lanes unchanged.

Signed-off-by: haic0 <haichzha@amd.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@vercel

vercel Bot commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
vllm-recipes Ready Ready Preview Sep 14, 2026 7:20am UTC

Request Review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the DeepSeek-V4-Pro configuration guide to specify a source Docker image and disables the VLLM_ROCM_USE_AITER_FUSION_SHARED_EXPERTS flag (setting it to 0) to avoid initialization failures on the nightly build. The review feedback recommends rephrasing the documentation to avoid a double negative, suggesting 'Set VLLM_ROCM_USE_AITER_FUSION_SHARED_EXPERTS=0 to disable it' instead of 'Disable VLLM_ROCM_USE_AITER_FUSION_SHARED_EXPERTS=0'.

was not running the configuration the validated manual runs used. The flag is
mutually exclusive with expert parallelism inside vLLM, which is consistent with
both arms running EP 1.
- Disable `VLLM_ROCM_USE_AITER_FUSION_SHARED_EXPERTS=0` for this nightly.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The phrasing 'Disable VLLM_ROCM_USE_AITER_FUSION_SHARED_EXPERTS=0' is slightly confusing and reads as a double negative (disabling a setting that is already 0/disabled). It would be clearer to state 'Set VLLM_ROCM_USE_AITER_FUSION_SHARED_EXPERTS=0 to disable it' or 'Disable shared-expert fusion by setting VLLM_ROCM_USE_AITER_FUSION_SHARED_EXPERTS=0'.

  - Set VLLM_ROCM_USE_AITER_FUSION_SHARED_EXPERTS=0 to disable it for this nightly.

@haic0 haic0 changed the title Fix InferenceX MI355X agentic source configuration Update InferenceX MI355X agentic recipes Sep 14, 2026
@shen-shanshan
shen-shanshan merged commit 6850dce into vllm-project:main Sep 14, 2026
4 checks passed

This branch was successfully deployed

1 active deployment
Preview — b5c04dee Deployed Sep 14, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants