Skip to content

Update MiniMax M3 for B300 NVFP4 - #730

Merged
faradawn merged 3 commits into
vllm-project:mainfrom
faradawn:minimaxm3-b300-fp4-eagle3-gqa
Aug 5, 2026
Merged

faradawn merged 3 commits into
vllm-project:mainfrom
faradawn:minimaxm3-b300-fp4-eagle3-gqa

Conversation

@faradawn

@faradawn faradawn commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Mark B300 as verified for MiniMax-M3, run the NVFP4 variant on FlashInfer TRT-LLM attention with the FP8 indexer KV cache, and document the B300 agentic-coding launch with the EAGLE3-GQA draft head. Best configs based on SemiAnalysisAI/InferenceX#2328.

@vercel

vercel Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
vllm-recipes Ready Ready Preview Aug 5, 2026 4:25pm

Request Review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support and verification for B300 hardware to the MiniMax-M3 model configuration, configures FlashInfer TRT-LLM attention kernels for the NVFP4 variant, and adds a guide section for agentic coding on B300. The review feedback correctly identifies that the newly added CLI arguments in extra_args use underscores (e.g., --attention_config) instead of hyphens (e.g., --attention-config), which would lead to unrecognized argument errors in vLLM.

Comment on lines +166 to +169
- "--attention_config.backend"
- "FLASHINFER"
- "--attention_config.use_trtllm_attention"
- "true"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The CLI arguments should use hyphens instead of underscores to match the standard vLLM argument format (e.g., --attention-config instead of --attention_config). Using underscores will result in an unrecognized arguments error from argparse when launching the server.

Note: Please also update the other occurrences of --attention_config in this file (such as lines 170 and 227-232) to use hyphens for consistency and correctness.

      - "--attention-config.backend"
      - "FLASHINFER"
      - "--attention-config.use_trtllm_attention"
      - "true"

Signed-off-by: Faradawn Yang <73060648+faradawn@users.noreply.github.com>
Signed-off-by: Faradawn Yang <73060648+faradawn@users.noreply.github.com>

@xinli-sw xinli-sw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the changes!

Signed-off-by: Faradawn Yang <73060648+faradawn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants