[AMD][ROCm]Minimax-M3 Eagle3 MTP attn backend override for perf - #615
Merged
Merged
Conversation
Signed-off-by: Hongxia Yang <hongxia.yang@amd.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces hardware overrides for AMD (ROCm) in the MiniMax-M3 model configuration, specifying the use of the 'TRITON_ATTN' attention backend instead of 'FLASH_ATTN' for speculative decoding to improve performance. There are no review comments, so I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Minimax-M3, override the drafter's attention backend to TRITON_ATTN.
When using eagle3 MTP:
Using
has much better performance than without it, like below:
For 8k/1k, con1 to con256, perf improved from 4% to 151%