Skip to content

[AMD][ROCm]Minimax-M3 Eagle3 MTP attn backend override for perf - #615

Merged
xianbaoqian merged 1 commit into
vllm-project:mainfrom
hongxiayang:rocm-mm3-eagle-mtp
Jul 7, 2026
Merged

[AMD][ROCm]Minimax-M3 Eagle3 MTP attn backend override for perf#615
xianbaoqian merged 1 commit into
vllm-project:mainfrom
hongxiayang:rocm-mm3-eagle-mtp

Conversation

@hongxiayang

@hongxiayang hongxiayang commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

For Minimax-M3, override the drafter's attention backend to TRITON_ATTN.

When using eagle3 MTP:
Using

    --speculative-config "{\"method\": \"eagle3\", \"model\": \"$DRAFT_MODEL\", \"num_speculative_tokens\": $NUM_SPEC_TOKENS, \"attention_backend\": \"TRITON_ATTN\"}" \

has much better performance than without it, like below:

    --speculative-config "{\"method\": \"eagle3\", \"model\": \"$DRAFT_MODEL\", \"num_speculative_tokens\": $NUM_SPEC_TOKENS} \

For 8k/1k, con1 to con256, perf improved from 4% to 151%

image

Signed-off-by: Hongxia Yang <hongxia.yang@amd.com>
@vercel

vercel Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
vllm-recipes Ready Ready Preview, Comment Jul 6, 2026 10:33pm

Request Review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces hardware overrides for AMD (ROCm) in the MiniMax-M3 model configuration, specifying the use of the 'TRITON_ATTN' attention backend instead of 'FLASH_ATTN' for speculative decoding to improve performance. There are no review comments, so I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants