Skip to content

[NV] Add MiniMax M3 Blackwell marlin TP8 recipe - #558

Closed
jasonlizhengjian wants to merge 1 commit into
vllm-project:mainfrom
jasonlizhengjian:codex-minimax-m3-blackwell-marlin-tp8
Closed

[NV] Add MiniMax M3 Blackwell marlin TP8 recipe#558
jasonlizhengjian wants to merge 1 commit into
vllm-project:mainfrom
jasonlizhengjian:codex-minimax-m3-blackwell-marlin-tp8

Conversation

@jasonlizhengjian

@jasonlizhengjian jasonlizhengjian commented Jun 16, 2026

Copy link
Copy Markdown

Summary

Adds --moe-backend marlin only to the MiniMax-M3 MXFP8 Blackwell TP8 recipe path.

Changes

  • Adds variant-scoped strategy/hardware override support in command synthesis.
  • Moves the Blackwell single_node_tp marlin override under the mxfp8 variant so the BF16 default path is unaffected.
  • Updates only the MiniMax-M3 MXFP8 TP8 guide command to include --moe-backend marlin.

Validation

  • git diff --check
  • node scripts/build-recipes-api.mjs
  • Confirmed generated BF16 B200 single_node_tp commands do not include --moe-backend marlin.
  • Confirmed generated MXFP8 B200 single_node_tp commands include --moe-backend marlin.
  • Confirmed generated MXFP8 H200, MXFP8 MI355X, and B200 single_node_tep commands do not include --moe-backend marlin.

@vercel

vercel Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
vllm-recipes Ready Ready Preview, Comment Jun 16, 2026 8:08pm

Request Review

@jasonlizhengjian
jasonlizhengjian force-pushed the codex-minimax-m3-blackwell-marlin-tp8 branch from a8518f7 to 5a83ca2 Compare June 16, 2026 19:54

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces strategy overrides and guide documentation for running the MiniMax-M3 model on NVIDIA Blackwell hardware using the Marlin MoE backend. However, the reviewer identified critical issues where the Marlin MoE backend is applied to the unquantized BF16 model (both in the global strategy overrides and the guide commands), which will cause runtime failures since Marlin MoE kernels do not support unquantized BF16 weights.

Comment thread models/MiniMaxAI/MiniMax-M3.yaml Outdated
Comment on lines +137 to +143
strategy_overrides:
single_node_tp:
hardware_overrides:
blackwell:
extra_args:
- "--moe-backend"
- "marlin"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Applying --moe-backend marlin globally under strategy_overrides for Blackwell will affect all variants, including the default BF16 model (MiniMaxAI/MiniMax-M3). Since Marlin MoE kernels in vLLM do not support unquantized BF16 weights, running the default BF16 recipe on Blackwell will fail at runtime.

If the schema supports it, please move this override under the mxfp8 variant configuration, or remove it from the global strategy_overrides to avoid breaking the BF16 path.

Comment thread models/MiniMaxAI/MiniMax-M3.yaml Outdated
Comment on lines +212 to +222
### NVIDIA Blackwell — TP8 (8x B200 / B300)

```bash
vllm serve MiniMaxAI/MiniMax-M3 \
--tensor-parallel-size 8 \
--block-size 128 \
--moe-backend marlin \
--tool-call-parser minimax_m3 \
--reasoning-parser minimax_m3 \
--enable-auto-tool-choice
```

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This guide section attempts to run the BF16 model (MiniMaxAI/MiniMax-M3) with --moe-backend marlin. Since Marlin MoE kernels do not support unquantized BF16 weights, this command will fail at runtime.

Since the BF16 model on Blackwell runs with the same parameters as Hopper, this section is redundant. Please remove this section or merge it with the Hopper section above.

@jasonlizhengjian
jasonlizhengjian force-pushed the codex-minimax-m3-blackwell-marlin-tp8 branch from 5a83ca2 to f86f6ea Compare June 16, 2026 20:03
@jasonlizhengjian jasonlizhengjian changed the title [codex] Add MiniMax M3 Blackwell marlin TP8 recipe [NV] Add MiniMax M3 Blackwell marlin TP8 recipe Jun 16, 2026
Signed-off-by: jasonlizhengjian <jasonlizhengjian@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant