Skip to content

[ROCm] Beam-1.0-501B-A23B: add AMD ROCm support - #1140

Closed
jamesETsmith wants to merge 2 commits into
vllm-project:mainfrom
jamesETsmith:beam-1.0-rocm-support
Closed

jamesETsmith wants to merge 2 commits into
vllm-project:mainfrom
jamesETsmith:beam-1.0-rocm-support

Conversation

@jamesETsmith

@jamesETsmith jamesETsmith commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Overview

The recipe marked all four AMD GPUs unsupported, because Beam's kernels were CUDA-only and only a CUDA image existed. vllm-project/vllm#62057 adds an AMD Beam implementation, validated on MI325X, MI350X, and MI355X, so this updates the recipe to match. Nothing changes for NVIDIA users.

🚧 leaving this PR as a draft until vllm-project/vllm#62057 is merged

Claims

  • Beam runs on ROCm. MI325X (gfx942) and MI350X/MI355X (gfx950) are verified; MI300X is supported through the same validated gfx942 code path.
  • BF16 only on AMD. So far only bf16 has been tested on AMD.
  • BF16 fits every AMD node. 1204 GB fits MI300X (1536), MI325X (2048) and MI350X/MI355X (2304), so they join supported_hardware.
  • DEP stays NVIDIA-only. The AMD path raises on sequence-parallel MoE, which is what DEP emits.
  • Per-brand images. AMD points at vllm/vllm-openai-rocm:nightly, the image that will eventually carry #62057.
  • AMD DFlash2 skips the attention backend pin. The NVIDIA drafter asserts FLASH_ATTN/FLASHINFER; the ROCm one delegates cache handling to the ROCm backend, so it doesn't need the pin.

Validation

  • node scripts/build-recipes-api.mjs → ✓ JSON API: 215 models, no schema failures.

  • node scripts/test-schema.mjs 4/4, node scripts/test-overlay.mjs 7/7.

  • Checked the generated commands for all four AMD GPUs: BF16 variant, TP8, DEP disabled, and:

    vllm serve reflection/Beam-1.0-501B-A23B \
      --tensor-parallel-size 8 \
      --attention-backend ROCM_AITER_UNIFIED_ATTN \
      --moe-backend triton
  • Serving evidence is #62057: BF16, TP8 + expert parallelism on MI325X, MI350X, and MI355X. Beam Verifier results reproduce Reflection's published BF16 accuracy within statistical error:

    • MI355X: GPQA-Diamond 90.06% and AIME 2026 97.45%, with both vanilla decoding and DFlash2.
    • MI325X: GPQA-Diamond 90.18%, with both vanilla decoding and DFlash2.

Details

One file, no schema or taxonomy changes. default_hardware stays b300; AMD users land on BF16 via default_variant. No NVIDIA behavior changed.

References

The recipe marked every AMD GPU unsupported because Beam's kernels were
CUDA-only and only a CUDA image was published. The ROCm model path replaces
the CUDA fast paths with standard ROCm attention, RCCL collectives and
AMD-local Triton kernels, so Beam now serves on gfx950 (MI350X/MI355X) and
gfx942 (MI300X/MI325X).

Validated end-to-end on 8x MI350X: BF16, TP8 with expert parallelism, plus
the DFlash2 drafter. Only BF16 runs on AMD, so the builder switches to it
there; DEP stays NVIDIA-only because the ROCm path raises on
sequence-parallel MoE.

The AMD DFlash2 config differs only in its attention backend: the ROCm
drafter defers cache handling to the selected ROCm backend, so it takes no
attention_backend pin. The draft token count is the same on both platforms.

Signed-off-by: jamesETsmith <james.smith9113@gmail.com>
@vercel

vercel Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
vllm-recipes Ready Ready Preview Oct 23, 2026 6:22pm UTC

Request Review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces AMD ROCm support for the Beam-1.0-501B-A23B model, enabling it to run on MI300X, MI325X, MI350X, and MI355X GPUs using the native BF16 checkpoint. It configures AMD-specific Docker images, hardware overrides, and attention/MoE backends, while updating the documentation guide to reflect these changes. The review feedback suggests enabling enable_adaptive_verification: true in both the AMD speculative decoding configuration and the corresponding guide example to maintain feature parity with the NVIDIA setup.

Comment on lines +85 to +89
hardware_overrides:
amd:
args:
- "--speculative-config"
- '{"method":"dflash","model":"reflection/Beam-1.0-501B-A23B-DFlash2","num_speculative_tokens":7}'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The speculative decoding configuration for AMD ROCm is missing the enable_adaptive_verification: true option. Adaptive verification is a platform-agnostic vLLM feature that helps improve throughput under load by only verifying draft tokens likely to be accepted. It should be enabled on AMD as well to maintain feature parity with the NVIDIA configuration.

    hardware_overrides:\n      amd:\n        args:\n          - "--speculative-config"\n          - '{"method":"dflash","model":"reflection/Beam-1.0-501B-A23B-DFlash2","num_speculative_tokens":7,"enable_adaptive_verification":true}'

attention backend, so the builder omits the FlashAttention pin:

```bash
--speculative-config '{"method":"dflash","model":"reflection/Beam-1.0-501B-A23B-DFlash2","num_speculative_tokens":7}'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Update the guide's speculative decoding example for AMD to include enable_adaptive_verification: true to match the recommended configuration.

  --speculative-config '{"method":"dflash","model":"reflection/Beam-1.0-501B-A23B-DFlash2","num_speculative_tokens":7,"enable_adaptive_verification":true}'

Mark MI325X verified and document accuracy validation across MI325X,
MI350X, and MI355X so the recipe reflects completed ROCm testing.

💘 Generated with Crush

Assisted-by: Crush:gpt-5.6-sol
Signed-off-by: jamesETsmith <james.smith9113@gmail.com>
@jamesETsmith

Copy link
Copy Markdown
Contributor Author

Missed #1107, so I'll add these recipes directly to my vllm PR vllm-project/vllm#62057

This branch was successfully deployed

1 active deployment
Preview — 6724091b Deployed Oct 23, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant