Repository navigation
[ROCm] Beam-1.0-501B-A23B: add AMD ROCm support - #1140
jamesETsmith wants to merge 2 commits into
Conversation
The recipe marked every AMD GPU unsupported because Beam's kernels were CUDA-only and only a CUDA image was published. The ROCm model path replaces the CUDA fast paths with standard ROCm attention, RCCL collectives and AMD-local Triton kernels, so Beam now serves on gfx950 (MI350X/MI355X) and gfx942 (MI300X/MI325X). Validated end-to-end on 8x MI350X: BF16, TP8 with expert parallelism, plus the DFlash2 drafter. Only BF16 runs on AMD, so the builder switches to it there; DEP stays NVIDIA-only because the ROCm path raises on sequence-parallel MoE. The AMD DFlash2 config differs only in its attention backend: the ROCm drafter defers cache handling to the selected ROCm backend, so it takes no attention_backend pin. The draft token count is the same on both platforms. Signed-off-by: jamesETsmith <james.smith9113@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Code Review
This pull request introduces AMD ROCm support for the Beam-1.0-501B-A23B model, enabling it to run on MI300X, MI325X, MI350X, and MI355X GPUs using the native BF16 checkpoint. It configures AMD-specific Docker images, hardware overrides, and attention/MoE backends, while updating the documentation guide to reflect these changes. The review feedback suggests enabling enable_adaptive_verification: true in both the AMD speculative decoding configuration and the corresponding guide example to maintain feature parity with the NVIDIA setup.
| hardware_overrides: | ||
| amd: | ||
| args: | ||
| - "--speculative-config" | ||
| - '{"method":"dflash","model":"reflection/Beam-1.0-501B-A23B-DFlash2","num_speculative_tokens":7}' |
There was a problem hiding this comment.
The speculative decoding configuration for AMD ROCm is missing the enable_adaptive_verification: true option. Adaptive verification is a platform-agnostic vLLM feature that helps improve throughput under load by only verifying draft tokens likely to be accepted. It should be enabled on AMD as well to maintain feature parity with the NVIDIA configuration.
hardware_overrides:\n amd:\n args:\n - "--speculative-config"\n - '{"method":"dflash","model":"reflection/Beam-1.0-501B-A23B-DFlash2","num_speculative_tokens":7,"enable_adaptive_verification":true}'| attention backend, so the builder omits the FlashAttention pin: | ||
|
|
||
| ```bash | ||
| --speculative-config '{"method":"dflash","model":"reflection/Beam-1.0-501B-A23B-DFlash2","num_speculative_tokens":7}' |
There was a problem hiding this comment.
Mark MI325X verified and document accuracy validation across MI325X, MI350X, and MI355X so the recipe reflects completed ROCm testing. 💘 Generated with Crush Assisted-by: Crush:gpt-5.6-sol Signed-off-by: jamesETsmith <james.smith9113@gmail.com>
|
Missed #1107, so I'll add these recipes directly to my vllm PR vllm-project/vllm#62057 |
Overview
The recipe marked all four AMD GPUs
unsupported, because Beam's kernels were CUDA-only and only a CUDA image existed. vllm-project/vllm#62057 adds an AMD Beam implementation, validated on MI325X, MI350X, and MI355X, so this updates the recipe to match. Nothing changes for NVIDIA users.🚧 leaving this PR as a draft until vllm-project/vllm#62057 is merged
Claims
verified; MI300X issupportedthrough the same validated gfx942 code path.supported_hardware.vllm/vllm-openai-rocm:nightly, the image that will eventually carry #62057.FLASH_ATTN/FLASHINFER; the ROCm one delegates cache handling to the ROCm backend, so it doesn't need the pin.Validation
node scripts/build-recipes-api.mjs→✓ JSON API: 215 models, no schema failures.node scripts/test-schema.mjs4/4,node scripts/test-overlay.mjs7/7.Checked the generated commands for all four AMD GPUs: BF16 variant, TP8, DEP disabled, and:
Serving evidence is #62057: BF16, TP8 + expert parallelism on MI325X, MI350X, and MI355X. Beam Verifier results reproduce Reflection's published BF16 accuracy within statistical error:
Details
One file, no schema or taxonomy changes.
default_hardwarestaysb300; AMD users land on BF16 viadefault_variant. No NVIDIA behavior changed.References