Repository navigation
[DeepSeek][ROCm] V4.1-Flash: enable mono decode on MI355X - #1094
Merged
Merged
Conversation
Set VLLM_ROCM_MONO_DECODE=1 in the MI355X single-node TP overrides. The mono decode layer from vllm-project/vllm#60397 uses two persistent launches per layer for decode steps of up to 48 rows, which with five DSpark drafts covers concurrency up to 8; larger steps take the regular path. Also trim the --no-swa-bounded-replay comment to the reason and the removal condition. Signed-off-by: Fangzhou Ai <31551580+Fangzhou-Ai@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable
VLLM_ROCM_MONO_DECODE=1in the MI355X single-node TP overrides. The mono decode layer from vllm-project/vllm#60397 uses two persistent launches per layer for decode steps of up to 48 rows; with five DSpark drafts that is concurrency 8, and larger steps take the regular path.Also trims the
--no-swa-bounded-replaycomment to the reason and the removal condition, and adds a short note to the MI355X section of the guide.Measurements
14-point agentic sweep on MI355X (DeepSeek-V4.1-Flash + DSpark k=5, TP2 and TP4, 1M context,
nightly-rocm100-7d0b4e57), compared against the same recipe on the previous pin:Grouped:
Caveat, stated plainly: the two sweeps are 296 upstream commits apart, so this is not a clean mono-decode-only A/B, and the c16/c32 improvements show that some of the gain comes from the rest of that range. What supports attributing the bulk of the low-concurrency gain to mono decode is the shape: the effect is largest at c1, decays monotonically with concurrency, and is gone at c64 (+0.3% / +0.5%), which is exactly the 48-row cutoff the kernel documents. I'm happy to run a single-variable A/B on one image if that would be preferred before merging.
GSM8K is unchanged across the sweep, and all 14 points plus the eval passed.
Validation
Note on #962
#962 is still open but conflicting, and its content (AMD image on the ROCm nightly channel, CK a8w4 expert selection) is already present on
main. It looks superseded and can probably be closed; this PR does not depend on it.