-
Notifications
You must be signed in to change notification settings - Fork 319
[Feat] Add basic integration path for semantic router #740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] Add basic integration path for semantic router #740
Conversation
Summary of ChangesHello @zerofishnoodles, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request lays the groundwork for integrating a semantic router into the vLLM Production Stack. The changes encompass significant updates to deployment configurations, a shift in Python dependency management tooling, and enhancements to the application's lifecycle management for routing components. The primary goal is to enable more intelligent request routing and provide clear documentation for users to leverage this new capability. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces an integration path for the vLLM Semantic Router, which is a significant new feature. The changes include extensive updates to Helm chart values across various routing configurations to support new lmcache features, and a new tutorial document has been added to guide users through the integration. Key code changes involve refactoring the routing logic management for more robust cleanup and reconfiguration, improving request proxying by sanitizing hop-by-hop headers, and modernizing the Docker build process by switching to uv. My review has identified a critical issue in the service_discovery module where a blocking call is used within an async function, which will freeze the event loop. I've also provided suggestions to improve the clarity of the new tutorial and the robustness of the Dockerfile. Overall, these are great additions, but the critical issue needs to be addressed.
214b973 to
985dacf
Compare
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces integration with the vLLM Semantic Router, adding a new tutorial and making related code adjustments. The modifications to the Helm chart and the request service are beneficial. The new tutorial is thorough, but I've provided some suggestions to enhance its clarity and reliability. Additionally, I've pointed out a potential issue in the sample values.yaml that might lead to deployment problems, along with a suggestion for a performance enhancement in the request handling code.
|
Please check whether the Gemini reviews need any fixes. Resolve all conversations that you believe are fine. Once everything is resolved, I’ll approve this PR. |
Signed-off-by: Rui Zhang <[email protected]>
Signed-off-by: Rui Zhang <[email protected]>
Signed-off-by: Rui Zhang <[email protected]>
b6aab6f to
719ba39
Compare
|
@Shaoting-Feng gemini fixed |
Shaoting-Feng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add basic integration path for semantic router
Related to #519 #734
Related to vllm-project/semantic-router#295
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE
-swhen doinggit commit[Bugfix],[Feat], and[CI].Detailed Checklist (Click to Expand)
Thank you for your contribution to production-stack! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]for bug fixes.[CI/Build]for build or continuous integration improvements.[Doc]for documentation fixes and improvements.[Feat]for new features in the cluster (e.g., autoscaling, disaggregated prefill, etc.).[Router]for changes to thevllm_router(e.g., routing algorithm, router observability, etc.).[Misc]for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
pre-committo format your code. SeeREADME.mdfor installation.DCO and Signed-off-by
When contributing changes to this project, you must agree to the DCO. Commits must include a
Signed-off-by:header which certifies agreement with the terms of the DCO.Using
-swithgit commitwill automatically add this header.What to Expect for the Reviews
We aim to address all PRs in a timely manner. If no one reviews your PR within 5 days, please @-mention one of YuhanLiu11
, Shaoting-Feng or ApostaC.