Skip to content

fix: Exclude content-length from response headers in route_general_transcriptions #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+7 −1
Open

fix: Exclude content-length from response headers in route_general_transcriptions #733

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c14e6c7
fix: Exclude content-length from response headers in route_general_tr…
fidoriel Oct 13, 2025
6fe9ae1
Merge branch 'main' into fix-exclude-content-length
zerofishnoodles Oct 27, 2025
1c5cc37
Merge branch 'main' into fix-exclude-content-length
zerofishnoodles Nov 14, 2025
751b21e
Merge branch 'main' into fix-exclude-content-length
zerofishnoodles Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/vllm_router/services/request_service/request.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,7 +668,13 @@ async def route_general_transcriptions(
headers = {
k: v
for k, v in backend_response.headers.items()
if k.lower() not in ("content-encoding", "transfer-encoding", "connection")
if k.lower()
not in (
"content-length",
"content-encoding",
"transfer-encoding",
"connection",
)
}
Comment on lines 668 to 678
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better readability and maintainability, it's a good practice to define the set of excluded headers separately. Using a set is also more idiomatic and typically more performant for membership testing than a tuple.

Suggested change
headers = {
k: v
for k, v in backend_response.headers.items()
if k.lower() not in ("content-encoding", "transfer-encoding", "connection")
if k.lower()
not in (
"content-length",
"content-encoding",
"transfer-encoding",
"connection",
)
}
excluded_headers = {
"content-length",
"content-encoding",
"transfer-encoding",
"connection",
}
headers = {
k: v
for k, v in backend_response.headers.items()
if k.lower() not in excluded_headers
}


headers["X-Request-Id"] = request_id
Expand Down