-
Notifications
You must be signed in to change notification settings - Fork 316
[Feat] Use the lmcache 0.3.5 for kvaware routing #673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] Use the lmcache 0.3.5 for kvaware routing #673
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @zerofishnoodles, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily focuses on integrating an updated version of the lmcache library to enhance kv-aware routing capabilities. It involves updating core dependencies, adjusting how lmcache messages are constructed to improve traceability, and modifying deployment configurations to support the new lmcache features, ensuring a more robust and observable routing mechanism.
Highlights
- Dependency Upgrade: The
lmcachelibrary has been upgraded to version 0.3.5, andhuggingface-hubhas been updated to 0.34.0, ensuring compatibility and leveraging new features from these versions. - LMcache Parameter Modification: Calls to
lmcachemessages (LookupMsgandQueryInstMsg) now include a uniqueevent_idparameter, which will aid in tracing and debugging within thelmcachesystem. - Environment Configuration Updates: New environment variables and configuration parameters related to
lmcache's distributed URL have been introduced in Helm templates and tutorial assets to support kv-aware routing setup. - Helm Chart Refinement: The router image tag in the Helm chart tutorial has been simplified from
kvaware-latesttolatest.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request upgrades lmcache to version 0.3.5 and adapts the code for KV-aware routing. The changes include updating dependencies, modifying Helm chart environment variables, and passing new event_id parameters in the routing logic. My review focuses on improving code consistency, maintainability, and removing outdated comments. I've identified a potentially inconsistent environment variable name, a stale comment in pyproject.toml, and a code duplication that could be refactored.
Signed-off-by: Rui Zhang <[email protected]>
e5f6657 to
64dc6e6
Compare
Shaoting-Feng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Rui Zhang <[email protected]> Signed-off-by: Nathan Price <[email protected]>
Signed-off-by: Rui Zhang <[email protected]> Signed-off-by: [email protected] <[email protected]>
[Feat] Use the lmcache 0.3.5 for kvaware routing
FIX #xxxx (link existing issues this PR will resolve)
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE
-swhen doinggit commit[Bugfix],[Feat], and[CI].Detailed Checklist (Click to Expand)
Thank you for your contribution to production-stack! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]for bug fixes.[CI/Build]for build or continuous integration improvements.[Doc]for documentation fixes and improvements.[Feat]for new features in the cluster (e.g., autoscaling, disaggregated prefill, etc.).[Router]for changes to thevllm_router(e.g., routing algorithm, router observability, etc.).[Misc]for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
pre-committo format your code. SeeREADME.mdfor installation.DCO and Signed-off-by
When contributing changes to this project, you must agree to the DCO. Commits must include a
Signed-off-by:header which certifies agreement with the terms of the DCO.Using
-swithgit commitwill automatically add this header.What to Expect for the Reviews
We aim to address all PRs in a timely manner. If no one reviews your PR within 5 days, please @-mention one of YuhanLiu11
, Shaoting-Feng or ApostaC.