Skip to content

[Build] use uv with cache mount for faster docker builds #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Build] use uv with cache mount for faster docker builds #657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
271691f
[Chore] sync out of date uv lockfile
Hexoplon Aug 23, 2025
ed2a620
[Build] use uv with cache mounts for faster docker builds
Hexoplon Aug 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 22 additions & 7 deletions docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
FROM python:3.12-slim

# Copy uv from the official uv Docker image (pinned version for reproducibility)
COPY --from=ghcr.io/astral-sh/uv:0.8.3 /uv /uvx /bin/

# Set environment variables for uv
ENV UV_SYSTEM_PYTHON=1

WORKDIR /app

# hadolint ignore=DL3008
Expand All @@ -8,19 +14,28 @@ RUN --mount=type=cache,target=/var/lib/apt --mount=type=cache,target=/var/cache/
apt-get install -y --no-install-recommends git && \
rm -rf /var/lib/apt/lists/*

# Copy the pyproject.toml and the git metadata first (leverage Docker layer caching)
COPY pyproject.toml .
# Copy the git metadata and source code
COPY .git/ .git/

# Copy the rest of the application code
COPY src/ src/

ARG INSTALL_OPTIONAL_DEP=semantic_cache,lmcache
ENV INSTALL_OPTIONAL_DEP=${INSTALL_OPTIONAL_DEP}

# Install dependencies (use cache, and delete after install, to speed up the build)
RUN pip install --upgrade --no-cache-dir pip setuptools_scm && \
pip install --no-cache-dir .[$INSTALL_OPTIONAL_DEP]
# Install dependencies first (for better Docker layer caching)
RUN --mount=type=cache,target=/root/.cache/uv \
--mount=type=bind,source=uv.lock,target=uv.lock \
--mount=type=bind,source=pyproject.toml,target=pyproject.toml \
if [ -n "$INSTALL_OPTIONAL_DEP" ]; then \
OLD_IFS="$IFS"; IFS=','; \
set --; \
for dep in $INSTALL_OPTIONAL_DEP; do \
[ -n "$dep" ] && set -- "$@" --extra "$dep"; \
done; \
IFS="$OLD_IFS"; \
uv sync --locked "$@"; \
else \
uv sync --locked; \
fi
Comment on lines +28 to +38
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Aug 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The shell script for handling optional dependencies is vulnerable to filename expansion (globbing) if a dependency name contains a wildcard character (e.g., *). It's safer to disable globbing with set -f during word splitting. I've also added comments to improve readability.

    if [ -n "$INSTALL_OPTIONAL_DEP" ]; then
        # Prevent globbing
        set -f;
        OLD_IFS="$IFS"; IFS=',';
        set --;
        for dep in $INSTALL_OPTIONAL_DEP; do
            [ -n "$dep" ] && set -- "$@" --extra "$dep";
        done;
        IFS="$OLD_IFS";
        # Re-enable globbing
        set +f;
        uv sync --locked "$@";
    else
        uv sync --locked;
    fi


# Set the entrypoint
ENTRYPOINT ["vllm-router"]
Expand Down
Loading