Skip to content

Conversation

@kobe0938
Copy link
Contributor

FILL IN THE PR DESCRIPTION HERE

revert uv.lock before #592

BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE


  • Make sure the code changes pass the pre-commit checks.
  • Sign-off your commit by using -s when doing git commit
  • Try to classify PRs for easy understanding of the type of changes, such as [Bugfix], [Feat], and [CI].
Detailed Checklist (Click to Expand)

Thank you for your contribution to production-stack! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.

PR Title and Classification

Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

  • [Bugfix] for bug fixes.
  • [CI/Build] for build or continuous integration improvements.
  • [Doc] for documentation fixes and improvements.
  • [Feat] for new features in the cluster (e.g., autoscaling, disaggregated prefill, etc.).
  • [Router] for changes to the vllm_router (e.g., routing algorithm, router observability, etc.).
  • [Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.

Code Quality

The PR need to meet the following code quality standards:

  • Pass all linter checks. Please use pre-commit to format your code. See README.md for installation.
  • The code need to be well-documented to ensure future contributors can easily understand the code.
  • Please include sufficient tests to ensure the change is stay correct and robust. This includes both unit tests and integration tests.

DCO and Signed-off-by

When contributing changes to this project, you must agree to the DCO. Commits must include a Signed-off-by: header which certifies agreement with the terms of the DCO.

Using -s with git commit will automatically add this header.

What to Expect for the Reviews

We aim to address all PRs in a timely manner. If no one reviews your PR within 5 days, please @-mention one of YuhanLiu11
, Shaoting-Feng or ApostaC.

Signed-off-by: Kobe Chen <[email protected]>
@gemini-code-assist
Copy link
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@YuhanLiu11 YuhanLiu11 merged commit 010e29d into vllm-project:main Jul 25, 2025
7 checks passed
ikaadil pushed a commit to ikaadil/production-stack that referenced this pull request Jul 26, 2025
Signed-off-by: Kobe Chen <[email protected]>
Signed-off-by: Ifta Khairul Alam Adil <[email protected]>
YuhanLiu11 added a commit that referenced this pull request Aug 5, 2025
…concurrency performance (#589)

* feat: update requirements to include aiohttp

Signed-off-by: Ifta khairul Alam Adil <[email protected]>
Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* feat: replace HTTPX with aiohttp for asynchronous client handling

Signed-off-by: Ifta khairul Alam Adil <[email protected]>
Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* feat: replace HTTPXClientWrapper with AiohttpClientWrapper for improved async handling

Signed-off-by: Ifta khairul Alam Adil <[email protected]>
Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* feat: replace HTTPXClientWrapper with AiohttpClientWrapper in lifespan management

Signed-off-by: Ifta khairul Alam Adil <[email protected]>
Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* feat: remove httpx from requirements for aiohttp integration

Signed-off-by: Ifta khairul Alam Adil <[email protected]>
Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* refactor: switch from httpx to aiohttp for asynchronous client handling in service discovery

Signed-off-by: Ifta khairul Alam Adil <[email protected]>
Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* feat: add AiohttpClientWrapper for asynchronous HTTP client handling

Signed-off-by: Ifta khairul Alam Adil <[email protected]>
Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* chore: pin aiohttp version to 3.9.5 in requirements

Signed-off-by: Ifta khairul Alam Adil <[email protected]>
Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* refactor: migrate from httpx to aiohttp for asynchronous HTTP requests in request service

Signed-off-by: Ifta khairul Alam Adil <[email protected]>
Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* refactor: update file upload implementation to use aiohttp for asynchronous requests

Signed-off-by: Ifta khairul Alam Adil <[email protected]>
Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* chore: replace httpx with aiohttp in project dependencies and test requirements

Signed-off-by: Ifta khairul Alam Adil <[email protected]>
Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* chore: format dependencies in pyproject.toml for consistency

Signed-off-by: Ifta khairul Alam Adil <[email protected]>
Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* chore: clean up imports and ensure consistent aiohttp version in requirements

Signed-off-by: Ifta khairul Alam Adil <[email protected]>
Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* fix: update aiohttp client closure method for consistency and accuracy in logging

Signed-off-by: Ifta khairul Alam Adil <[email protected]>
Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* fix: correct status code handling in request processing for improved response accuracy

Signed-off-by: Ifta khairul Alam Adil <[email protected]>
Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* bumping version (#593)

Signed-off-by: YuhanLiu11 <[email protected]>
Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* Added option to specify priority class (#557)

Signed-off-by: Fabijan Marič Vild <[email protected]>
Co-authored-by: Yuhan Liu <[email protected]>
Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* [CI/Build] Change CI runner to L4 (#595)

* Add env clean up before run

Signed-off-by: Shaoting Feng <[email protected]>

* Delete all pods

Signed-off-by: Shaoting Feng <[email protected]>

* Delete all release

Signed-off-by: Shaoting Feng <[email protected]>

* test ci runner

Signed-off-by: Shaoting <[email protected]>

* test ci runner

Signed-off-by: Shaoting <[email protected]>

* Test again

Signed-off-by: Shaoting Feng <[email protected]>

* Test again

Signed-off-by: Shaoting Feng <[email protected]>

* Change python version from 3.12 to 3.10

Signed-off-by: Shaoting Feng <[email protected]>

* delete get helm

Signed-off-by: Shaoting Feng <[email protected]>

* change back python version

Signed-off-by: Shaoting Feng <[email protected]>

* trigger

Signed-off-by: Shaoting Feng <[email protected]>

* Add cache: pip

Signed-off-by: Shaoting Feng <[email protected]>

* Try check-latest: true

Signed-off-by: Shaoting Feng <[email protected]>

* Changing to 3.10

Signed-off-by: Shaoting Feng <[email protected]>

* change to 3.9

Signed-off-by: Shaoting Feng <[email protected]>

* Specify 3.9.2

Signed-off-by: Shaoting Feng <[email protected]>

* Use conda python

Signed-off-by: Shaoting Feng <[email protected]>

* Fix vllm without conda

Signed-off-by: Shaoting Feng <[email protected]>

---------

Signed-off-by: Shaoting Feng <[email protected]>
Signed-off-by: Shaoting <[email protected]>
Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* [Bugfix] fix dynamic config (#598)

* [hotfix] fix dynamic config

Signed-off-by: Rui Zhang <[email protected]>

* [Bugfix] Add missing field for reconfiguration

Signed-off-by: Rui Zhang <[email protected]>

---------

Signed-off-by: Rui Zhang <[email protected]>
Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* [refactor] redesign RST documentation (#592)

* initial reorg

Signed-off-by: Kobe Chen <[email protected]>

* pass CICD

Signed-off-by: Kobe Chen <[email protected]>

* fix

Signed-off-by: Kobe Chen <[email protected]>

* fix

Signed-off-by: Kobe Chen <[email protected]>

* fix: update helm.rst

Signed-off-by: Kobe Chen <[email protected]>

* fix

Signed-off-by: Kobe Chen <[email protected]>

* fix

Signed-off-by: Kobe Chen <[email protected]>

* Sharing KV Cache Across Instances

Signed-off-by: Kobe Chen <[email protected]>

* docker

Signed-off-by: Kobe Chen <[email protected]>

* community meeting

Signed-off-by: Kobe Chen <[email protected]>

* add deployment 3 options

Signed-off-by: Kobe Chen <[email protected]>

* remove A:

Signed-off-by: Kobe Chen <[email protected]>

* docker

Signed-off-by: Kobe Chen <[email protected]>

---------

Signed-off-by: Kobe Chen <[email protected]>
Co-authored-by: Yuhan Liu <[email protected]>
Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* [Misc] revert uv.lock (#604)

Signed-off-by: Kobe Chen <[email protected]>
Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* fix: update response content iteration method for improved performance

Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* Replace httpx with aiohttp for prefill and decode clients in K8sServiceNameServiceDiscovery, updating timeout handling accordingly.

Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* Update file upload function to include file parameter in aiohttp post request

Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* Refactor response handling in request service to return JSON data and correctly set response status code in sleep/wakeup routing.

Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* Add initialization of aiohttp ClientSession in service discovery during app startup

- Implemented  method in , , and  classes to set up aiohttp ClientSession for prefill and decode endpoints.
- Updated  function in  to call  if available, ensuring proper session management during application startup.
- Adjusted logging statements in  to reference the  attribute of the client sessions for accurate logging of routing requests.

Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* Refactor whitespace and formatting in app.py for improved readability

Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

---------

Signed-off-by: Ifta khairul Alam Adil <[email protected]>
Signed-off-by: Ifta Khairul Alam Adil <[email protected]>
Signed-off-by: YuhanLiu11 <[email protected]>
Signed-off-by: Fabijan Marič Vild <[email protected]>
Signed-off-by: Shaoting Feng <[email protected]>
Signed-off-by: Shaoting <[email protected]>
Signed-off-by: Rui Zhang <[email protected]>
Signed-off-by: Kobe Chen <[email protected]>
Co-authored-by: Yuhan Liu <[email protected]>
Co-authored-by: Fabhiahn <[email protected]>
Co-authored-by: Shaoting <[email protected]>
Co-authored-by: Rui Zhang <[email protected]>
Co-authored-by: Kobe Chen <[email protected]>
Senne-Mennes pushed a commit to Senne-Mennes/production-stack that referenced this pull request Oct 22, 2025
Senne-Mennes pushed a commit to Senne-Mennes/production-stack that referenced this pull request Oct 22, 2025
…concurrency performance (vllm-project#589)

* feat: update requirements to include aiohttp

Signed-off-by: Ifta khairul Alam Adil <[email protected]>
Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* feat: replace HTTPX with aiohttp for asynchronous client handling

Signed-off-by: Ifta khairul Alam Adil <[email protected]>
Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* feat: replace HTTPXClientWrapper with AiohttpClientWrapper for improved async handling

Signed-off-by: Ifta khairul Alam Adil <[email protected]>
Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* feat: replace HTTPXClientWrapper with AiohttpClientWrapper in lifespan management

Signed-off-by: Ifta khairul Alam Adil <[email protected]>
Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* feat: remove httpx from requirements for aiohttp integration

Signed-off-by: Ifta khairul Alam Adil <[email protected]>
Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* refactor: switch from httpx to aiohttp for asynchronous client handling in service discovery

Signed-off-by: Ifta khairul Alam Adil <[email protected]>
Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* feat: add AiohttpClientWrapper for asynchronous HTTP client handling

Signed-off-by: Ifta khairul Alam Adil <[email protected]>
Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* chore: pin aiohttp version to 3.9.5 in requirements

Signed-off-by: Ifta khairul Alam Adil <[email protected]>
Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* refactor: migrate from httpx to aiohttp for asynchronous HTTP requests in request service

Signed-off-by: Ifta khairul Alam Adil <[email protected]>
Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* refactor: update file upload implementation to use aiohttp for asynchronous requests

Signed-off-by: Ifta khairul Alam Adil <[email protected]>
Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* chore: replace httpx with aiohttp in project dependencies and test requirements

Signed-off-by: Ifta khairul Alam Adil <[email protected]>
Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* chore: format dependencies in pyproject.toml for consistency

Signed-off-by: Ifta khairul Alam Adil <[email protected]>
Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* chore: clean up imports and ensure consistent aiohttp version in requirements

Signed-off-by: Ifta khairul Alam Adil <[email protected]>
Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* fix: update aiohttp client closure method for consistency and accuracy in logging

Signed-off-by: Ifta khairul Alam Adil <[email protected]>
Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* fix: correct status code handling in request processing for improved response accuracy

Signed-off-by: Ifta khairul Alam Adil <[email protected]>
Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* bumping version (vllm-project#593)

Signed-off-by: YuhanLiu11 <[email protected]>
Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* Added option to specify priority class (vllm-project#557)

Signed-off-by: Fabijan Marič Vild <[email protected]>
Co-authored-by: Yuhan Liu <[email protected]>
Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* [CI/Build] Change CI runner to L4 (vllm-project#595)

* Add env clean up before run

Signed-off-by: Shaoting Feng <[email protected]>

* Delete all pods

Signed-off-by: Shaoting Feng <[email protected]>

* Delete all release

Signed-off-by: Shaoting Feng <[email protected]>

* test ci runner

Signed-off-by: Shaoting <[email protected]>

* test ci runner

Signed-off-by: Shaoting <[email protected]>

* Test again

Signed-off-by: Shaoting Feng <[email protected]>

* Test again

Signed-off-by: Shaoting Feng <[email protected]>

* Change python version from 3.12 to 3.10

Signed-off-by: Shaoting Feng <[email protected]>

* delete get helm

Signed-off-by: Shaoting Feng <[email protected]>

* change back python version

Signed-off-by: Shaoting Feng <[email protected]>

* trigger

Signed-off-by: Shaoting Feng <[email protected]>

* Add cache: pip

Signed-off-by: Shaoting Feng <[email protected]>

* Try check-latest: true

Signed-off-by: Shaoting Feng <[email protected]>

* Changing to 3.10

Signed-off-by: Shaoting Feng <[email protected]>

* change to 3.9

Signed-off-by: Shaoting Feng <[email protected]>

* Specify 3.9.2

Signed-off-by: Shaoting Feng <[email protected]>

* Use conda python

Signed-off-by: Shaoting Feng <[email protected]>

* Fix vllm without conda

Signed-off-by: Shaoting Feng <[email protected]>

---------

Signed-off-by: Shaoting Feng <[email protected]>
Signed-off-by: Shaoting <[email protected]>
Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* [Bugfix] fix dynamic config (vllm-project#598)

* [hotfix] fix dynamic config

Signed-off-by: Rui Zhang <[email protected]>

* [Bugfix] Add missing field for reconfiguration

Signed-off-by: Rui Zhang <[email protected]>

---------

Signed-off-by: Rui Zhang <[email protected]>
Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* [refactor] redesign RST documentation (vllm-project#592)

* initial reorg

Signed-off-by: Kobe Chen <[email protected]>

* pass CICD

Signed-off-by: Kobe Chen <[email protected]>

* fix

Signed-off-by: Kobe Chen <[email protected]>

* fix

Signed-off-by: Kobe Chen <[email protected]>

* fix: update helm.rst

Signed-off-by: Kobe Chen <[email protected]>

* fix

Signed-off-by: Kobe Chen <[email protected]>

* fix

Signed-off-by: Kobe Chen <[email protected]>

* Sharing KV Cache Across Instances

Signed-off-by: Kobe Chen <[email protected]>

* docker

Signed-off-by: Kobe Chen <[email protected]>

* community meeting

Signed-off-by: Kobe Chen <[email protected]>

* add deployment 3 options

Signed-off-by: Kobe Chen <[email protected]>

* remove A:

Signed-off-by: Kobe Chen <[email protected]>

* docker

Signed-off-by: Kobe Chen <[email protected]>

---------

Signed-off-by: Kobe Chen <[email protected]>
Co-authored-by: Yuhan Liu <[email protected]>
Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* [Misc] revert uv.lock (vllm-project#604)

Signed-off-by: Kobe Chen <[email protected]>
Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* fix: update response content iteration method for improved performance

Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* Replace httpx with aiohttp for prefill and decode clients in K8sServiceNameServiceDiscovery, updating timeout handling accordingly.

Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* Update file upload function to include file parameter in aiohttp post request

Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* Refactor response handling in request service to return JSON data and correctly set response status code in sleep/wakeup routing.

Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* Add initialization of aiohttp ClientSession in service discovery during app startup

- Implemented  method in , , and  classes to set up aiohttp ClientSession for prefill and decode endpoints.
- Updated  function in  to call  if available, ensuring proper session management during application startup.
- Adjusted logging statements in  to reference the  attribute of the client sessions for accurate logging of routing requests.

Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

* Refactor whitespace and formatting in app.py for improved readability

Signed-off-by: Ifta Khairul Alam Adil <[email protected]>

---------

Signed-off-by: Ifta khairul Alam Adil <[email protected]>
Signed-off-by: Ifta Khairul Alam Adil <[email protected]>
Signed-off-by: YuhanLiu11 <[email protected]>
Signed-off-by: Fabijan Marič Vild <[email protected]>
Signed-off-by: Shaoting Feng <[email protected]>
Signed-off-by: Shaoting <[email protected]>
Signed-off-by: Rui Zhang <[email protected]>
Signed-off-by: Kobe Chen <[email protected]>
Co-authored-by: Yuhan Liu <[email protected]>
Co-authored-by: Fabhiahn <[email protected]>
Co-authored-by: Shaoting <[email protected]>
Co-authored-by: Rui Zhang <[email protected]>
Co-authored-by: Kobe Chen <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants