-
Notifications
You must be signed in to change notification settings - Fork 321
[Feat][Router]: add vision model type #603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f49ddf0 to
1e8ca2c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @max-wittig, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've implemented changes to the vllm_router to introduce explicit support for vision models. This involves defining a new ModelType for vision and providing a concrete example of a multimodal request payload, which will allow the router to properly handle and test requests for models that can process both text and image inputs.
Highlights
- New Model Type Definition: I've introduced a new
visionmember to theModelTypeenum insrc/vllm_router/utils.py. This new type is associated with the/v1/chat/completionsendpoint, indicating its use for chat-based vision models. - Multimodal Test Payload: I've extended the
get_test_payloadstatic method to include a sample request body for the newly addedModelType.vision. This payload demonstrates a multimodal input structure, including both text and a base64-encoded image URL, which is crucial for testing vision model capabilities.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new vision model type. However, due to a shared value with the existing chat model type in the ModelType enum, the new type is created as an alias, which breaks the intended functionality. I've provided a critical feedback with a suggestion to resolve this by making the enum value unique.
b35f9f8 to
f8c6f64
Compare
|
@gemini-code-assist review again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a vision model type and refactors the ModelType enum to better separate concerns. The changes are generally good, but there are a few opportunities for improvement in code conciseness and idiomatic Python usage. I've suggested combining match cases and correcting how static methods are called.
68f105e to
96eeac2
Compare
ff3fb8f to
954be79
Compare
|
@zerofishnoodles could you take a look at this one? |
zerofishnoodles
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@max-wittig Can you merge the latest changes from the main? |
Signed-off-by: Max Wittig <[email protected]>
Head branch was pushed to by a user without write access
954be79 to
0444889
Compare
|
@YuhanLiu11 Rebased. |
Signed-off-by: Max Wittig <[email protected]> Signed-off-by: Nathan Price <[email protected]>
Signed-off-by: Max Wittig <[email protected]> Signed-off-by: [email protected] <[email protected]>
Adds a vision model type so that the health-check can also work for those models
-swhen doinggit commit[Bugfix],[Feat], and[CI].Detailed Checklist (Click to Expand)
Thank you for your contribution to production-stack! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]for bug fixes.[CI/Build]for build or continuous integration improvements.[Doc]for documentation fixes and improvements.[Feat]for new features in the cluster (e.g., autoscaling, disaggregated prefill, etc.).[Router]for changes to thevllm_router(e.g., routing algorithm, router observability, etc.).[Misc]for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
pre-committo format your code. SeeREADME.mdfor installation.DCO and Signed-off-by
When contributing changes to this project, you must agree to the DCO. Commits must include a
Signed-off-by:header which certifies agreement with the terms of the DCO.Using
-swithgit commitwill automatically add this header.What to Expect for the Reviews
We aim to address all PRs in a timely manner. If no one reviews your PR within 5 days, please @-mention one of YuhanLiu11
, Shaoting-Feng or ApostaC.