Skip to content

[Bugfix] fix dynamic config #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2025
Merged

[Bugfix] fix dynamic config #598

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22c610b
[hotfix] fix dynamic config
zerofishnoodles Jul 23, 2025
193000c
[Bugfix] Add missing field for reconfiguration
zerofishnoodles Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/vllm_router/dynamic_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,12 +137,14 @@ def reconfigure_service_discovery(self, config: DynamicRouterConfig):
if config.service_discovery == "static":
reconfigure_service_discovery(
ServiceDiscoveryType.STATIC,
app=self.app,
urls=parse_static_urls(config.static_backends),
models=parse_comma_separated_args(config.static_models),
)
elif config.service_discovery == "k8s":
reconfigure_service_discovery(
ServiceDiscoveryType.K8S,
app=self.app,
namespace=config.k8s_namespace,
port=config.k8s_port,
label_selector=config.k8s_label_selector,
Expand Down
12 changes: 6 additions & 6 deletions src/vllm_router/service_discovery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,12 +206,12 @@ def __init__(
app,
urls: List[str],
models: List[str],
aliases: List[str] | None,
model_labels: List[str] | None,
model_types: List[str] | None,
static_backend_health_checks: bool,
prefill_model_labels: List[str] | None,
decode_model_labels: List[str] | None,
aliases: List[str] | None = None,
model_labels: List[str] | None = None,
model_types: List[str] | None = None,
static_backend_health_checks: bool = False,
prefill_model_labels: List[str] | None = None,
decode_model_labels: List[str] | None = None,
):
self.app = app
assert len(urls) == len(models), "URLs and models should have the same length"
Expand Down