Skip to content

Remove GPTQ Group/Dynamic Activation Ordering - #3038

Merged
dsikka merged 11 commits into
mainfrom
Roderick-Wu/deprecate-actorder
Aug 25, 2026
Merged

dsikka merged 11 commits into
mainfrom
Roderick-Wu/deprecate-actorder

Conversation

@Roderick-Wu

@Roderick-Wu Roderick-Wu commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

Removing GPTQ activation order dynamic/group (already deprecated). Goes along with compressed-tensors change:
vllm-project/compressed-tensors#840

Signed-off-by: Roderick Wu <rowu@redhat.com>
@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 1560614d-361f-4dcd-8b29-16352363c16b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

@mergify

mergify Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

The quality checks have failed. Please run make style and make quality under
the root directory to adddress the lint failures. You will need to install the
dev optional install to get the required linting packages:
https://github.com/vllm-project/llm-compressor/blob/main/CONTRIBUTING.md

@mergify

mergify Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Merge Protections

🟢 Merge protection satisfied — ready to merge.

Show 1 satisfied protection

🟢 Require one maintainer review

All PRs must have at least one approving review from a maintainer before merging.

  • #changes-requested-reviews-by = 0
  • any of:
    • approved-reviews-by=kylesayrs
    • approved-reviews-by=HDCharles
    • approved-reviews-by=brian-dellabetta
    • approved-reviews-by=dsikka
    • approved-reviews-by=yiliu30

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes support for the deprecated ActivationOrdering.GROUP ("group") activation ordering strategy and its associated weight_g_idx parameter across the codebase, including documentation, modifiers, quantization logic, and tests. Feedback on the changes highlights three main areas of improvement: a critical correctness bug in quantize_weight where g_idx is not permuted when actorder is set to "static", an outdated return type annotation in quantize_weight that still expects a 5-tuple instead of the updated 2-tuple, and the need to explicitly raise a ValueError when actorder="group" is supplied to prevent silent failures.

Comment thread src/llmcompressor/modifiers/gptq/gptq_quantize.py
Comment thread src/llmcompressor/modifiers/gptq/gptq_quantize.py
Comment thread src/llmcompressor/modifiers/gptq/base.py
@mergify mergify Bot removed the quality-failed label Aug 18, 2026
@mergify

mergify Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

The quality checks have failed. Please run make style and make quality under
the root directory to adddress the lint failures. You will need to install the
dev optional install to get the required linting packages:
https://github.com/vllm-project/llm-compressor/blob/main/CONTRIBUTING.md

@Roderick-Wu
Roderick-Wu marked this pull request as ready for review August 19, 2026 20:52
@mergify mergify Bot removed the quality-failed label Aug 19, 2026
@Roderick-Wu Roderick-Wu added the ready When a PR is ready for full CI testing before merge label Aug 19, 2026

@kylesayrs kylesayrs left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, awesome work

@kylesayrs
kylesayrs enabled auto-merge (squash) August 19, 2026 20:59

@kylesayrs kylesayrs left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, awesome work

Comment thread src/llmcompressor/modifiers/gptq/gptq_quantize.py
@mergify

mergify Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

The quality checks have failed. Please run make style and make quality under
the root directory to adddress the lint failures. You will need to install the
dev optional install to get the required linting packages:
https://github.com/vllm-project/llm-compressor/blob/main/CONTRIBUTING.md

Signed-off-by: Roderick Wu <rowu@redhat.com>
@mergify mergify Bot removed the quality-failed label Aug 20, 2026
@mergify

mergify Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

The quality checks have failed. Please run make style and make quality under
the root directory to adddress the lint failures. You will need to install the
dev optional install to get the required linting packages:
https://github.com/vllm-project/llm-compressor/blob/main/CONTRIBUTING.md

@mergify mergify Bot removed the quality-failed label Aug 20, 2026
@mergify

mergify Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

The quality checks have failed. Please run make style and make quality under
the root directory to adddress the lint failures. You will need to install the
dev optional install to get the required linting packages:
https://github.com/vllm-project/llm-compressor/blob/main/CONTRIBUTING.md

Signed-off-by: Roderick Wu <rowu@redhat.com>
@mergify mergify Bot removed the quality-failed label Aug 20, 2026
@Roderick-Wu Roderick-Wu changed the title Remove GPTQ Activation Ordering Remove GPTQ Group/Dynamic Activation Ordering Aug 20, 2026
dsikka and others added 3 commits August 22, 2026 22:41
Signed-off-by: Roderick Wu <rowu@redhat.com>
Signed-off-by: Roderick Wu <rowu@redhat.com>
@dsikka
dsikka enabled auto-merge (squash) August 25, 2026 22:49
@dsikka
dsikka merged commit 1b0d3e2 into main Aug 25, 2026
8 checks passed
@dsikka
dsikka deleted the Roderick-Wu/deprecate-actorder branch August 25, 2026 22:49
kylesayrs pushed a commit that referenced this pull request Aug 26, 2026
Removing GPTQ activation order dynamic/group (already deprecated). Goes
along with compressed-tensors change:
vllm-project/compressed-tensors#840

---------

Signed-off-by: Roderick Wu <rowu@redhat.com>
Co-authored-by: Roderick Wu <rowu@redhat.com>
Co-authored-by: Dipika Sikka <dipikasikka1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready When a PR is ready for full CI testing before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants