[MXFP4] Move out of experimental folder#2685
Conversation
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughDocumentation links referencing MXFP4 quantization examples are redirected from the ChangesMXFP4 Example Documentation Reorganization
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request migrates MXFP4 quantization examples from the experimental directory to the main examples directory. The review feedback focuses on maintaining consistency and documentation quality: it suggests removing an inconsistent trailing slash in the README, aligning relative paths in the AutoRound documentation, and updating the 'What's New!' and 'Known Issues' sections to reflect current support status. Additionally, it is recommended to move and update the existing README rather than deleting it to ensure the new directory remains well-documented.
|
@coderabbitai the w4a16 label is incorrect. this is w4a4 |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Repository: vllm-project/llm-compressor 🏁 Script executed: Repository: vllm-project/llm-compressor 🏁 Script executed: Length of output: 76 🏁 Script executed: Repository: vllm-project/llm-compressor 🏁 Script executed: Repository: vllm-project/llm-compressor 🏁 Script executed: Repository: vllm-project/llm-compressor
✏️ Learnings added
|
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Dipika Sikka <ds3822@columbia.edu>
SUMMARY: