Updates to docs; move mxfp8 examples#2673
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughDocumentation updates across contributing and main README files. CONTRIBUTING.md adds a developer guide link for extending LLM Compressor. README.md reorganizes quantization sections with thematic example groupings and updates user guides. A deprecated sparse quantization example README is removed. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
There was a problem hiding this comment.
Code Review
This pull request updates the documentation by adding a link to the Developer Guide in CONTRIBUTING.md and significantly reorganizing the End-to-End Examples in the README.md into categorized sections like Weight and Activation, Weight Only, and Architecture-Specific quantization. It also updates several documentation links and removes a file related to unsupported Sparse24 models. The review feedback identifies several opportunities for improvement in the README, including correcting grammatical errors in the quantization guide description, ensuring consistent punctuation and capitalization (specifically for NVFP4), and maintaining uniform link formatting by removing trailing slashes.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@README.md`:
- Line 70: The sentence in README.md contains a grammar error: change "selecting
a quantization schemes" to either "selecting a quantization scheme" (singular)
or "selecting quantization schemes" (plural) in the line that reads "Please
refer to our [step-by-step compression
guide](https://docs.vllm.ai/projects/llm-compressor/en/latest/steps/choosing-model/)
for detailed information about selecting a quantization schemes, algorithm, and
their use cases." Update the phrase so the article ("a") matches singular
"scheme" or remove "a" to use the plural "schemes", and ensure the rest of the
clause ("algorithm, and their use cases") reads consistently with that choice.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 4433ad92-ca66-4cec-8c70-f000acc7f98d
📒 Files selected for processing (6)
CONTRIBUTING.mdREADME.mdexamples/quantization_w8a8_mxfp8/autoround_qwen3_example.pyexamples/quantization_w8a8_mxfp8/qwen3_example_w8a16_mxfp8.pyexamples/quantization_w8a8_mxfp8/qwen3_example_w8a8_mxfp8.pyexamples/sparse_2of4_quantization_fp8/README.md
💤 Files with no reviewable changes (1)
- examples/sparse_2of4_quantization_fp8/README.md
|
The quality checks have failed. Please run |
|
The quality checks have failed. Please run |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Dipika Sikka <ds3822@columbia.edu>
|
The quality checks have failed. Please run |
|
The links in the autoround readme are failing - I can just remove them? |
SUMMARY: