-
Notifications
You must be signed in to change notification settings - Fork 355
Add NPU support. #2200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add NPU support. #2200
Conversation
Summary of ChangesHello @menogrey, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the hardware compatibility of Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for NPU devices to accelerate quantization, which is a valuable addition. The changes correctly detect NPU availability in gpu_if_available, dispatch_for_sequential, and the environment collection script. My main feedback is regarding code duplication for device detection logic, which is now present in two separate files. I've left a comment suggesting a refactor to centralize this logic for better maintainability. Otherwise, the changes look good.
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
|
My quantization script The output: |
Co-authored-by: LHXuuu <[email protected]> Signed-off-by: menogrey <[email protected]>
e780612 to
318c4dd
Compare
brian-dellabetta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! looks good to me
SUMMARY:
Add NPU support for llm-compressor, to accelerate the quantization on NPU devices. Related issue #2199
TEST PLAN:
Test branch: main
Tested with extra dependencies. The
torch-npuadd NPU support for Pytorch.We tested int8_w8a8 quantization on Qwen3-30B-A3B model.