Conversation
Summary of ChangesHello @kylesayrs, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing code maintainability and reducing technical debt by systematically removing dead code and centralizing common utility functions. By eliminating unused helper functions and consolidating shared utilities into the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request effectively removes deprecated utility functions and their associated imports and tests from llmcompressor.utils.helpers.py. Functions like getattr_chain and patch_attr have been consolidated into compressed_tensors.utils, leading to a cleaner and more maintainable codebase for llmcompressor. The changes are well-executed and align with the stated purpose of removing dead code. No issues of medium, high, or critical severity were found during the review.
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
## Purpose ## * These utils haven't been used in almost two years. Let's deprecate them before the next release ## After Release ## * #2098 --------- Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
brian-dellabetta
left a comment
There was a problem hiding this comment.
would it be good to merge this post-release?
2485f76 to
165babd
Compare
|
@Mergifyio refresh |
✅ Pull request refreshed |
brian-dellabetta
left a comment
There was a problem hiding this comment.
I think we should merge this in if checks are still passing 🧹
Purpose