-
Notifications
You must be signed in to change notification settings - Fork 276
Drop support for python 3.9 #1910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Dan Huang <[email protected]>
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
Summary of ChangesHello @dhuangnm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request formally drops support for Python 3.9, establishing Python 3.10 as the new minimum required version for the project. The changes ensure that both the project's installation instructions and its build configuration accurately reflect this updated dependency, streamlining future development and leveraging newer Python features. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly updates the minimum required Python version from 3.9 to 3.10 across the documentation and setup.py. The changes are straightforward and well-executed. I have one suggestion to enhance the package metadata in setup.py by explicitly listing the supported Python versions in the classifiers, which would provide better clarity for users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm from docs. Should also be added to the relevant release notes.
Signed-off-by: Dan Huang <[email protected]>
faadc24
SUMMARY: Update minimum support python version to 3.10 TEST PLAN: All tests Signed-off-by: Dan Huang <[email protected]> Signed-off-by: LeiZhang <[email protected]>
SUMMARY:
Update minimum support python version to 3.10
A successful run with 3.13 is here: https://github.com/neuralmagic/llm-compressor-testing/actions/runs/18411151926/job/52463532345
TEST PLAN:
All tests