Skip to content

Conversation

@dhuangnm
Copy link
Collaborator

@dhuangnm dhuangnm commented Oct 9, 2025

SUMMARY:
Update minimum support python version to 3.10

A successful run with 3.13 is here: https://github.com/neuralmagic/llm-compressor-testing/actions/runs/18411151926/job/52463532345

TEST PLAN:
All tests

@github-actions
Copy link

github-actions bot commented Oct 9, 2025

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @dhuangnm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request formally drops support for Python 3.9, establishing Python 3.10 as the new minimum required version for the project. The changes ensure that both the project's installation instructions and its build configuration accurately reflect this updated dependency, streamlining future development and leveraging newer Python features.

Highlights

  • Minimum Python Version Update: The project's minimum supported Python version has been updated from 3.9 to 3.10.
  • Documentation Alignment: All relevant documentation files (compress.md, deploy.md, install.md) have been updated to reflect the new Python 3.10 requirement.
  • Build Configuration: The setup.py file has been modified to enforce the python_requires setting to >=3.10.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/quality-check.yaml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates the minimum required Python version from 3.9 to 3.10 across the documentation and setup.py. The changes are straightforward and well-executed. I have one suggestion to enhance the package metadata in setup.py by explicitly listing the supported Python versions in the classifiers, which would provide better clarity for users.

dsikka
dsikka previously approved these changes Oct 9, 2025
@dsikka dsikka added the ready When a PR is ready for review label Oct 9, 2025
aireilly
aireilly previously approved these changes Oct 9, 2025
Copy link
Collaborator

@aireilly aireilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm from docs. Should also be added to the relevant release notes.

@dsikka dsikka added ready When a PR is ready for review and removed ready When a PR is ready for review labels Oct 9, 2025
@dsikka dsikka enabled auto-merge (squash) October 9, 2025 16:52
@dhuangnm dhuangnm dismissed stale reviews from aireilly, dsikka, and brian-dellabetta via faadc24 October 10, 2025 14:46
@dsikka dsikka merged commit d27a5d7 into main Oct 10, 2025
9 checks passed
@dsikka dsikka deleted the drop3.9 branch October 10, 2025 18:55
zhanglei1172 pushed a commit to zhanglei1172/llm-compressor that referenced this pull request Oct 17, 2025
SUMMARY:
Update minimum support python version to 3.10

TEST PLAN:
All tests

Signed-off-by: Dan Huang <[email protected]>
Signed-off-by: LeiZhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready When a PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants