Skip to content

Conversation

@brian-dellabetta
Copy link
Collaborator

@brian-dellabetta brian-dellabetta commented Sep 23, 2025

SUMMARY:
Clear out some deprecation warnings in logs:

  • Replace pynvml with nvidia-ml-py (which has the same API):
../../../../../opt/hostedtoolcache/Python/3.12.11/x64/lib/python3.12/site-packages/torch/cuda/__init__.py:63
  /opt/hostedtoolcache/Python/3.12.11/x64/lib/python3.12/site-packages/torch/cuda/__init__.py:63: FutureWarning: The pynvml package is deprecated. Please install nvidia-ml-py instead. If you did not install pynvml directly, please report this to the maintainers of the package that installed pynvml for you.
    import pynvml  # type: ignore[import]
  • Replacesafe_permute(x,y, dim=d) with x.index_select(dim=d, index=y):
tests/llmcompressor/observers/test_min_max.py::test_g_idx
  /opt/hostedtoolcache/Python/3.12.11/x64/lib/python3.12/site-packages/llmcompressor/observers/base.py:172: DeprecationWarning: safe_permute is deprecated and will be removed in a future release. Please use Tensor.index_select instead.
    observed = safe_permute(observed, perm, dim=1)
  • Only display warning for MagnituePruningModifier.leave_enabled if field has been set to something other than default value
  /opt/hostedtoolcache/Python/3.12.11/x64/lib/python3.12/site-packages/llmcompressor/modifiers/pruning/magnitude/base.py:43: DeprecationWarning: MagnitudePruningModifier.leave_enable has been deprecated
    warnings.warn(

TEST PLAN:
No net new src code, tests pass

Signed-off-by: Brian Dellabetta <[email protected]>
@github-actions
Copy link

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

@brian-dellabetta brian-dellabetta marked this pull request as ready for review September 23, 2025 20:48
Copy link
Collaborator

@fynnsu fynnsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Don't forget to add ready label

@brian-dellabetta brian-dellabetta added the ready When a PR is ready for review label Sep 23, 2025
Copy link
Collaborator

@dhuangnm dhuangnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran nightly tests with the new dependencies and they look good.

@brian-dellabetta brian-dellabetta merged commit bfa02eb into main Sep 24, 2025
8 checks passed
@brian-dellabetta brian-dellabetta deleted the bdellabe/pynvml-remove branch September 24, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready When a PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants