Conversation
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @kylesayrs, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily aims to update the allowed version range for the transformers library, enabling compatibility with newer versions, including 4.53 and beyond. To ensure continued functionality and stability with these updated dependencies, several adjustments have been made to the tracing mechanisms, particularly concerning how attention mask creation functions are handled during model tracing.
Highlights
- Dependency Update: The
transformerslibrary dependency insetup.pyhas been unpinned, removing the upper version limit of<4.53.0to allow for installation of newer versions. - Expanded Tracing Ignore List: The
tracing_ignorelist inDatasetArgumentshas been significantly expanded to include a comprehensive set of attention mask creation functions, preventing them from being traced. - Centralized Tracing Ignore Configuration: The
debug.pyscript now dynamically retrieves the default tracing ignore list fromDatasetArguments, ensuring consistency across the codebase. - Tracer Integration for Masking: The
SequentialTracernow explicitly incorporates known mask function patterns from thetransformerslibrary into itsautowrap_functionslist, further refining the tracing process for compatibility. - Autowrapper Debug Logging Refinement: Debug logging within the
auto_wrapper.pymodule has been refactored to be more precise, logging the created function definition only after it has been fully constructed.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
kylesayrs
force-pushed
the
kylesayrs/unpin-transformers-53
branch
from
e8e691c to
cde7095
Compare
|
FYI cannot land until nightly passes: https://github.com/neuralmagic/llm-compressor-testing/actions/runs/15985058411 Seems to be vllm issues |
|
Custom Run: https://github.com/neuralmagic/llm-compressor-testing/actions/runs/16120509664 (for e2e) |
## Prerequisites ## * vllm-project#1599 --------- Signed-off-by: Kyle Sayers <kylesayrs@gmail.com> Co-authored-by: Dipika Sikka <dipikasikka1@gmail.com>
5 participants
Prerequisites