Skip to content

Comments

[Transformers] Pin to <4.53#1598

Merged
kylesayrs merged 1 commit intomainfrom
pin_transformers_453
Jun 27, 2025
Merged

[Transformers] Pin to <4.53#1598
kylesayrs merged 1 commit intomainfrom
pin_transformers_453

Conversation

@dsikka
Copy link
Collaborator

@dsikka dsikka commented Jun 26, 2025

SUMMARY:

  • Pin until we resolve

@github-actions
Copy link

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

@dsikka dsikka marked this pull request as ready for review June 26, 2025 17:11
@dsikka dsikka added the ready When a PR is ready for review label Jun 26, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @dsikka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a temporary version pin for the transformers library dependency. The intent is to prevent potential compatibility issues or breaking changes that might occur with newer versions of the library, ensuring the stability of the current build until a more permanent resolution can be implemented.

Highlights

  • Dependency Version Pinning: The transformers library dependency in setup.py has been updated to restrict its maximum allowed version to less than 4.53.0. Previously, the constraint allowed versions up to 5.0.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request pins the transformers dependency to a specific version (<4.53.0) in setup.py. This is likely done to avoid compatibility issues or bugs introduced in later versions. While pinning dependencies can be a temporary solution, it's important to monitor the pinned dependency for security updates and compatibility with other libraries. Adding a comment explaining the reason for pinning and a plan to update it in the future would be beneficial.

@dsikka dsikka enabled auto-merge (squash) June 26, 2025 17:14
Copy link
Collaborator

@kylesayrs kylesayrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth checking if #1599 fixes most of them?

@dsikka
Copy link
Collaborator Author

dsikka commented Jun 26, 2025

Is it worth checking if #1599 fixes most of them?

Yeah we can merge this if it does not

@dsikka dsikka disabled auto-merge June 26, 2025 17:28
@dsikka dsikka closed this Jun 26, 2025
@kylesayrs kylesayrs reopened this Jun 27, 2025
@kylesayrs kylesayrs merged commit 9341907 into main Jun 27, 2025
16 checks passed
@kylesayrs kylesayrs deleted the pin_transformers_453 branch June 27, 2025 14:35
brian-dellabetta pushed a commit that referenced this pull request Jun 27, 2025
SUMMARY:
- Pin until we resolve
kylesayrs pushed a commit that referenced this pull request Jun 30, 2025
SUMMARY:
- Pin until we resolve
aireilly pushed a commit to aireilly/llm-compressor that referenced this pull request Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready When a PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants