Skip to content

Add group act order case to lm_eval test #1080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dsikka merged 6 commits into from
Feb 21, 2025
Merged

Add group act order case to lm_eval test #1080

dsikka merged 6 commits into from
Feb 21, 2025

Conversation

@dsikka
Copy link
Collaborator

@dsikka dsikka commented Jan 17, 2025 •
edited
Loading

SUMMARY:

Testing:

  • Test passes locally with transformers 4.49

@github-actions
Copy link

github-actions bot commented Jan 17, 2025

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

@dsikka dsikka marked this pull request as ready for review January 21, 2025 12:30
@dsikka dsikka added the ready When a PR is ready for review label Jan 21, 2025
@dsikka dsikka marked this pull request as draft January 23, 2025 00:47
@dsikka dsikka removed the ready When a PR is ready for review label Jan 23, 2025
@dsikka dsikka marked this pull request as ready for review February 19, 2025 18:43
@dsikka dsikka added the ready When a PR is ready for review label Feb 20, 2025
kylesayrs
kylesayrs approved these changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@kylesayrs kylesayrs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that the comment hasn't landed yet

@dsikka dsikka enabled auto-merge (squash) February 21, 2025 01:07
@dsikka dsikka merged commit 5a82dcc into main Feb 21, 2025
7 checks passed
@dsikka dsikka deleted the update_lm_eval branch February 21, 2025 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brian-dellabetta brian-dellabetta brian-dellabetta approved these changes

@kylesayrs kylesayrs kylesayrs approved these changes

Assignees

No one assigned

Labels

ready When a PR is ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dsikka @brian-dellabetta @kylesayrs