Merged
Conversation
Author
|
waiting: Dao-AILab#1904 (comment) |
johnnynunez
force-pushed
the
main
branch
2 times, most recently
from
23a6d73 to
6ed2576
Compare
Author
|
@ProExpertProg ready to merge |
Signed-off-by: johnnynunez <johnnynuca14@gmail.com>
Signed-off-by: johnnynunez <johnnynuca14@gmail.com>
Signed-off-by: johnnynunez <johnnynuca14@gmail.com>
ProExpertProg
approved these changes
Sep 24, 2025
ProExpertProg
approved these changes
Sep 25, 2025
Collaborator
|
If anyone has time can they test this with torch 2.8? if not I will test it tomorrow before landing 👍 |
Author
it is here running now: vllm-project/vllm#25695 |
Collaborator
|
Running a longer build here: https://buildkite.com/vllm/ci/builds/33143#0199a333-a3a5-4a3b-a2b9-4682b3d60b1b |
Author
seems was stopped for external reason |
Collaborator
|
Went ahead and built it locally; looks good 👍 |
LucasWilkinson
approved these changes
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The errors in flash_api_sparse.cpp and hopper/flash_api.cpp are C++11 narrowing warnings (treated as errors in strict builds) when initializing at::cuda::CUDAGuard with a non-constant char cast to c10::DeviceIndex (signed char).
Previously, integer division caused num_consumer_warpgroups_per_cluster to be 0 when params.num_consumers (e.g., 32) was less than NumThreadsPerWarpGroup (128), leading to a compiler failure during barrier initialization. Changed to round-up division to ensure a minimum value of 1.
Add Thor support