[Easy] replace c10::optional with std::optional#58
Merged
WoosukKwon merged 1 commit intovllm-project:mainfrom Mar 27, 2025
Merged
[Easy] replace c10::optional with std::optional#58WoosukKwon merged 1 commit intovllm-project:mainfrom
WoosukKwon merged 1 commit intovllm-project:mainfrom
Conversation
Signed-off-by: Ye (Charlotte) Qi <yeq@meta.com>
WoosukKwon
approved these changes
Mar 27, 2025
Collaborator
WoosukKwon
left a comment
WoosukKwon
left a comment
There was a problem hiding this comment.
LGTM, but I think this issue will be recurring unless we fix it on the original repo?
Author
|
these c10::optional does not come from upstream FA tho. |
Collaborator
|
@yeqcharlotte Got it. Thanks for the fix! |
LucasWilkinson
pushed a commit
that referenced
this pull request
Apr 1, 2025
Signed-off-by: Ye (Charlotte) Qi <yeq@meta.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seeing build issues on this. c10::optional is being deprecated.
This is similar issue addressed in vllm-project/vllm#11730.
Run this e2e internally.