Make vllm's FA2 ABI stable - #175
Merged
Merged
Conversation
Signed-off-by: Jane Xu <janeyx@meta.com>
janeyx99
force-pushed
the
vllm-fa2-stable-abi
branch
from
July 30, 2026 20:38
93455d2 to
02f09f2
Compare
4 tasks
Harry-Chen
approved these changes
Jul 31, 2026
Harry-Chen
left a comment
Harry-Chen
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks!
vllm CI pipeline: https://buildkite.com/vllm/ci/builds/81411
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tl;dr: make vllm's FA2 ABI stable with torch!
This adapts from #153 and mimics the not-yet landed Dao-AILab#2688. It may take a while for that PR to land so I'd recommend just going forward with this once the tests are ascertained in vllm-project/vllm#50474