Skip to content

Remove Group ActivationOrdering Again - #868

Closed
Roderick-Wu wants to merge 1 commit into
mainfrom
Roderick-Wu/remove-actoder-enum
Closed

Roderick-Wu wants to merge 1 commit into
mainfrom
Roderick-Wu/remove-actoder-enum

Conversation

@Roderick-Wu

@Roderick-Wu Roderick-Wu commented Sep 8, 2026 •

Copy link
Copy Markdown
Collaborator

Signed-off-by: Roderick Wu <Roderick-Wu@h100-03.nemg-001.lab.rdu2.dc.redhat.com>
@coderabbitai

coderabbitai Bot commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: fce74d22-8fb4-4100-812b-7acef7bc70f8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mergify

mergify Bot commented Sep 8, 2026 •

Copy link
Copy Markdown

Merge Protections

🔴 1 of 1 protections blocking · waiting on 👀 reviews

Protection Waiting on
🔴 Require one maintainer review 👀 reviews

🔴 Require one maintainer review

Waiting for

  • #changes-requested-reviews-by = 0
  • any of:
    • approved-reviews-by=HDCharles
    • approved-reviews-by=brian-dellabetta
    • approved-reviews-by=dsikka
    • approved-reviews-by=kylesayrs
This rule is failing.

All PRs must have at least one approving review from a maintainer before merging.

  • #changes-requested-reviews-by = 0
  • any of:
    • approved-reviews-by=HDCharles
    • approved-reviews-by=brian-dellabetta
    • approved-reviews-by=dsikka
    • approved-reviews-by=kylesayrs

@Roderick-Wu
Roderick-Wu marked this pull request as ready for review September 9, 2026 14:01
@Roderick-Wu Roderick-Wu added the ready When a PR is ready for full CI testing before merge label Sep 9, 2026

@kylesayrs kylesayrs left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there's virtually no cost to maintaining this anymore, I think we should keep these to avoid issues where users use the wrong version of vLLM and CT together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready When a PR is ready for full CI testing before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants