[ROCm][CI] Add ROCm Docker Hub registry cache and weekly cleanup pipeline#307
Open
AndreasKaratzas wants to merge 9 commits intomainfrom
Open
[ROCm][CI] Add ROCm Docker Hub registry cache and weekly cleanup pipeline#307AndreasKaratzas wants to merge 9 commits intomainfrom
AndreasKaratzas wants to merge 9 commits intomainfrom
Conversation
…line Signed-off-by: Andreas Karatzas <akaratza@amd.com>
…line Signed-off-by: Andreas Karatzas <akaratza@amd.com>
…line Signed-off-by: Andreas Karatzas <akaratza@amd.com>
…line Signed-off-by: Andreas Karatzas <akaratza@amd.com>
…line Signed-off-by: Andreas Karatzas <akaratza@amd.com>
…line Signed-off-by: Andreas Karatzas <akaratza@amd.com>
…line Signed-off-by: Andreas Karatzas <akaratza@amd.com>
…line Signed-off-by: Andreas Karatzas <akaratza@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rocm/vllm-ci-cache) with 4-layer fallback: exact commit -> parent commit -> merge-base with main ->rocm-latestbaseline.|shell block tocommands:+env:block. Switches to pinnedbash .buildkite/scripts/ci-bake.sh(in vllm repo) instead of curl-at-runtime. Main-branch builds now writerocm-latestviaDOCKERHUB_CACHE_TO.git merge-baseresolves correctly for cache key computation.rocm-<sha>tags older than 30 days from Docker Hub, keepingrocm-latestpermanently.Requires
DOCKERHUB_USERNAME+DOCKERHUB_TOKENsecrets on the cleanup pipeline.This PR is connected to: vllm-project/vllm#36949
These two PRs should likely be merged simultaneously.
cc @kenroche @okakarpa @tjtanaa @khluu