[ROCm] pass AMD test commands via VLLM_TEST_COMMANDS env var to fix quoting#298
Merged
khluu merged 1 commit intovllm-project:mainfrom Mar 2, 2026
Merged
Conversation
…uoting Signed-off-by: Andreas Karatzas <akaratza@amd.com>
5ab346b to
5881d57
Compare
Collaborator
|
is this change meant for CI or AMD CI? |
Collaborator
Author
|
I think it addresses a failure mostly on CI, and not AMD CI. So far AMD CI does not have that failure. However I was thinking of modifying the relative part on AMD CI as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AMD mirror steps fail with
/bin/sh: 1: Syntax error: "(" unexpectedbeforerun-amd-test.sheven executes. This affects any test step with pytest marker expressions like-m 'core_model and (not slow_test)'.The pipeline generator's
_prepare_commandsconverts single quotes to double quotes and injectsCUDA_COREDUMP_GENERATION_FLAGS="skip_...". When these are passed as a positional argument wrapped in outer double quotes:Fix
Pass commands via the
VLLM_TEST_COMMANDSenvironment variable instead of as a positional argument. Buildkite sets env vars directly in the process environment without shell interpretation, so all inner quoting is preserved.Motivation
cc @kenroche