Skip to content

[ROCm] pass AMD test commands via VLLM_TEST_COMMANDS env var to fix quoting#298

Merged
khluu merged 1 commit intovllm-project:mainfrom
AndreasKaratzas:akaratza_rocm_fix
Mar 2, 2026
Merged

[ROCm] pass AMD test commands via VLLM_TEST_COMMANDS env var to fix quoting#298
khluu merged 1 commit intovllm-project:mainfrom
AndreasKaratzas:akaratza_rocm_fix

Conversation

@AndreasKaratzas
Copy link
Collaborator

AMD mirror steps fail with /bin/sh: 1: Syntax error: "(" unexpected before run-amd-test.sh even executes. This affects any test step with pytest marker expressions like -m 'core_model and (not slow_test)'.

The pipeline generator's _prepare_commands converts single quotes to double quotes and injects CUDA_COREDUMP_GENERATION_FLAGS="skip_...". When these are passed as a positional argument wrapped in outer double quotes:

bash run-amd-test.sh "... CUDA_COREDUMP_GENERATION_FLAGS="skip_..." && ... -m "core_model and (not slow_test)""

Fix

Pass commands via the VLLM_TEST_COMMANDS environment variable instead of as a positional argument. Buildkite sets env vars directly in the process environment without shell interpretation, so all inner quoting is preserved.

Motivation

cc @kenroche

…uoting

Signed-off-by: Andreas Karatzas <akaratza@amd.com>
@khluu
Copy link
Collaborator

khluu commented Mar 2, 2026

is this change meant for CI or AMD CI?

@AndreasKaratzas
Copy link
Collaborator Author

I think it addresses a failure mostly on CI, and not AMD CI. So far AMD CI does not have that failure. However I was thinking of modifying the relative part on AMD CI as well.

@khluu khluu merged commit af158ac into vllm-project:main Mar 2, 2026
1 check passed
@AndreasKaratzas AndreasKaratzas deleted the akaratza_rocm_fix branch March 2, 2026 22:26
khluu added a commit that referenced this pull request Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants