Skip to content

Skip hardware tests on docs-only changes #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seemethere merged 3 commits into from
Sep 29, 2025
Merged

Skip hardware tests on docs-only changes #177

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
20e42d9
skip hardware tests on docs-only changes; add docs_only detection in …
Sep 29, 2025
bc04139
ci(buildkite): robust docs_only calculation; avoid length on iterator
Sep 29, 2025
6c452a2
Merge branch 'main' into ci/docs-only-skip-hw-tests
rzabarazesh Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions buildkite/test-template-ci.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,14 @@
{% set hf_home_fsx = "/fsx/hf_cache" %}
{% set list_file_diff = list_file_diff | split("|") %}

{% set docs_check = namespace(all_docs=true, found_any=false) %}
{% for file in list_file_diff %}
{% set docs_check.found_any = true %}
{% if file[:5] != 'docs/' %}
{% set docs_check.all_docs = false %}
{% endif %}
{% endfor %}
{% set docs_only = (docs_check.all_docs and docs_check.found_any) %}
{% macro add_pytest_coverage(cmd, coverage_file) %}
{% if "pytest " in cmd %}
COVERAGE_FILE={{ coverage_file }} {{ cmd | replace("pytest ", "pytest --cov=vllm --cov-report= --cov-append --durations=0 ") }} || true
Expand Down Expand Up @@ -529,6 +537,7 @@ steps:
{% endif %}
{% endfor %}

{% if not docs_only %}
- label: "Neuron Test"
depends_on: ~
agents:
Expand Down Expand Up @@ -701,6 +710,7 @@ steps:
- "vllm#tpu-ci-notifications"
YAML
fi
{% endif %}
{% endif %}

{% if cov_enabled %}
Expand Down