Fix CUTLASS DSL 4.6.0 compatibility - #8
Conversation
Co-authored-by: OpenAI Codex <codex@openai.com> Signed-off-by: wzhao18 <wzhao18.sz@gmail.com>
| nvidia-cutlass-dsl>=4.4.1 | ||
| quack-kernels>=0.2.10 | ||
| nvidia-cutlass-dsl>=4.6.0 | ||
| quack-kernels>=0.6.1 |
There was a problem hiding this comment.
Currently vllm requires quack-kernels>=0.4.0. In that case do we need to align vllm requirements with MSA requirements?
There was a problem hiding this comment.
I can in this pr vllm-project/vllm#49016 to together update.
There was a problem hiding this comment.
@arpera Should we pin to an exact version? With quack-kernels>=xxx I believe it will just install the latest version.
@lengrongfu Sounds good. We can update the version there when we update the MSA commit hash. Thanks!
There was a problem hiding this comment.
I think there is no need to pin an exact version here since we only need at least 0.6.1. Also, leave please a comment in the files where you update version of quack-kernels to know exactly why we need at least 0.6.1 installed.
|
cc @yongye |
vllm bumped cute dsl version to 4.6.0, this PR fixes various compatibility issues introduced by the version bump.
Validated that all unit tests are now passing:
E2E Minimax: