Skip to content

Commit

Permalink
Fix condition to skip building frontend (microsoft#561)
Browse files Browse the repository at this point in the history
and replace "Copilot Chat" with "Chat Copilot" to test it

### Motivation and Context
Save time by not building the frontend files when we only are doing a PR
for backend files

### Description
Remove the "=" that was messing up the boolean evaluation.

Replace a bunch of "Copilot Chat" strings with "Chat Copilot" to verify
fix.

### Contribution Checklist
- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [Contribution
Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
  • Loading branch information
glahaye authored Oct 31, 2023
1 parent 81fdf2a commit 2a3273b
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/copilot-build-backend.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ jobs:
- name: Package Copilot Chat WebAPI
run: |
scripts\deploy\package-webapi.ps1 -Configuration Release -DotnetFramework net6.0 -TargetRuntime win-x64 -OutputDirectory ${{ github.workspace }}\scripts\deploy -Version ${{ steps.versiontag.outputs.versiontag }} -InformationalVersion "Built from commit ${{ steps.gitversion.outputs.ShortSha }} on $(Get-Date -Format 'yyyy-MM-dd')" -SkipFrontendFiles=${{ github.event_name == 'pull_request' }}
scripts\deploy\package-webapi.ps1 -Configuration Release -DotnetFramework net6.0 -TargetRuntime win-x64 -OutputDirectory ${{ github.workspace }}\scripts\deploy -Version ${{ steps.versiontag.outputs.versiontag }} -InformationalVersion "Built from commit ${{ steps.gitversion.outputs.ShortSha }} on $(Get-Date -Format 'yyyy-MM-dd')" -SkipFrontendFiles ('${{ github.event_name == 'pull_request' }}' -eq 'true')
- name: Upload package to artifacts
uses: actions/upload-artifact@v3
Expand Down
2 changes: 1 addition & 1 deletion webapi/Extensions/SemanticKernelExtensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ private static void InitializeKernelProvider(this WebApplicationBuilder builder)
/// </summary>
private static Task RegisterChatCopilotSkillsAsync(IServiceProvider sp, IKernel kernel)
{
// Copilot chat skills
// Chat Copilot skills
kernel.RegisterChatSkill(sp);

// Time skill
Expand Down
2 changes: 1 addition & 1 deletion webapi/Extensions/ServiceExtensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ namespace CopilotChat.WebApi.Extensions;

/// <summary>
/// Extension methods for <see cref="IServiceCollection"/>.
/// Add options and services for Copilot Chat.
/// Add options and services for Chat Copilot.
/// </summary>
public static class CopilotChatServiceExtensions
{
Expand Down
2 changes: 1 addition & 1 deletion webapi/Models/Response/ChatArchive.cs
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public class ChatArchive
public Dictionary<string, List<Citation>> Embeddings { get; set; } = new Dictionary<string, List<Citation>>();

/// <summary>
/// The embeddings of uploaded documents in Copilot Chat. It represents the document memory which is accessible to all chat sessions of a given user.
/// The embeddings of uploaded documents in Chat Copilot. It represents the document memory which is accessible to all chat sessions of a given user.
/// </summary>
public Dictionary<string, List<Citation>> DocumentEmbeddings { get; set; } = new Dictionary<string, List<Citation>>();
}
2 changes: 1 addition & 1 deletion webapi/Program.cs
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
namespace CopilotChat.WebApi;

/// <summary>
/// Copilot Chat Service
/// Chat Copilot Service
/// </summary>
public sealed class Program
{
Expand Down
6 changes: 3 additions & 3 deletions webapi/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ To enable sequential planner,
return new SequentialPlanner(this.Kernel, new SequentialPlannerConfig { RelevancyThreshold = 0.75 }).CreatePlanAsync(goal);
```
\* The `RelevancyThreshold` is a number from 0 to 1 that represents how similar a goal is to a function's name/description/inputs. You want to tune that value when using SequentialPlanner to help keep things scoped while not missing on on things that are relevant or including too many things that really aren't. `0.75` is an arbitrary threshold and we recommend developers play around with this number to see what best fits their scenarios.
1. Restart the `webapi` - Copilot Chat should be now running locally with SequentialPlanner.
1. Restart the `webapi` - Chat Copilot should be now running locally with SequentialPlanner.
## (Optional) Enabling Cosmos Chat Store.
Expand All @@ -125,7 +125,7 @@ In an effort to optimize performance, each container must be created with a spec
By default, the service uses an in-memory volatile memory store that, when the service stops or restarts, forgets all memories.
[Qdrant](https://github.com/qdrant/qdrant) is a persistent scalable vector search engine that can be deployed locally in a container or [at-scale in the cloud](https://github.com/Azure-Samples/qdrant-azure).
To enable the Qdrant memory store, you must first deploy Qdrant locally and then configure the Copilot Chat API service to use it.
To enable the Qdrant memory store, you must first deploy Qdrant locally and then configure the Chat Copilot API service to use it.
### 1. Configure your environment
Expand Down Expand Up @@ -153,7 +153,7 @@ Before you get started, make sure you have the following additional requirements
## (Optional) Enabling the Azure Cognitive Search Memory Store

Azure Cognitive Search can be used as a persistent memory store for Copilot Chat.
Azure Cognitive Search can be used as a persistent memory store for Chat Copilot.
The service uses its [vector search](https://learn.microsoft.com/en-us/azure/search/vector-search-overview) capabilities.

## (Optional) Enable Application Insights telemetry
Expand Down

0 comments on commit 2a3273b

Please sign in to comment.