Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ls implementation with extras #183

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ls implementation with extras #183

wants to merge 1 commit into from

Conversation

mike-ward
Copy link
Contributor

Includes most of the usual ls features plus some extras like table format, checksums and icons.

@spytheman
Copy link
Member

(rebased over latest main, to avoid the mkfifo type mismatch error, that was already fixed on main)

@spytheman
Copy link
Member

Hi, sorry for the delay.

I just tried the PR, and got a different output with -l:
image

vs

image

@spytheman
Copy link
Member

spytheman commented Dec 26, 2024

While I do prefer the output of your version, since it is clearer and easier to read to me,
I think that the goal of the project was to emulate the original GNU coreutils as close as possible, including sorting order and result formatting, so that the tools can be tested/compared against each other.

@JalonSolov
Copy link
Contributor

If you wanted to add an option (that wouldn't be tested against the GNU version), to give the nicer output, that's fine. The default using the regular options should match.

@mike-ward
Copy link
Contributor Author

mike-ward commented Dec 27, 2024

makes sense. I'll see what I can do. Also I'm using GNU ls. The ls in Mac is different option-wise and sometimes layout-wise from gls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants