Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to the build tool #1846

Merged
merged 2 commits into from
May 1, 2024
Merged

Updates to the build tool #1846

merged 2 commits into from
May 1, 2024

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented May 1, 2024 •
edited
Loading

Summary:

This PR:

  • Adds a save document call before generating a build document or a preview.
  • Restores the scroll bar position if a build preview is updated.

Related Issue(s):

Closes #1835
Closes #1837

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.4.1 milestone May 1, 2024
This was linked to issues May 1, 2024
Build Tool Preview Position #1837
Closed
Build Manager: Save Project missing before Build, Preview and Print actions #1835
Closed
@vkbo vkbo merged commit 3b7459f into release May 1, 2024
9 checks passed
@vkbo vkbo deleted the fixes/build_usability branch May 1, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 2.4.1
Development

Successfully merging this pull request may close these issues.

Build Tool Preview Position Build Manager: Save Project missing before Build, Preview and Print actions
1 participant
@vkbo