Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fast document read #1777

Merged
merged 3 commits into from
Mar 26, 2024
Merged

Add fast document read #1777

merged 3 commits into from
Mar 26, 2024

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Mar 26, 2024

Summary:

This PR adds an alternative and efficient way to read the text of a document when all that is needed is the text content with the meta data stripped. The reader is added as a static method in the NWDocument class, and a wrapper function is added to the NWStorage class.

Related Issue(s):

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.4 Beta 1 milestone Mar 26, 2024
@vkbo vkbo merged commit 8bb0588 into dev Mar 26, 2024
9 checks passed
@vkbo vkbo deleted the fast_doc_read branch March 26, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant