Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix i18n issues #1754

Merged
merged 6 commits into from
Mar 12, 2024
Merged

Fix i18n issues #1754

merged 6 commits into from
Mar 12, 2024

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Mar 12, 2024 •
edited
Loading

Summary:

This PR resolves the following:

  • Missing translation string on dialog due to wrong formatting.
  • Don't assume the add chapter/scene strings on the Welcome dialog's new project form can be split after "Add".

Related Issue(s):

Closes #1749
Closes #1750

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.3.1 milestone Mar 12, 2024
@vkbo vkbo merged commit 9a9b2c6 into main Mar 12, 2024
9 checks passed
@vkbo vkbo deleted the i18n_fixes branch March 12, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 2.3.1
Development

Successfully merging this pull request may close these issues.

Crowdin: [empty translation] is overridden by English translation Untranslated string due to syntax error
1 participant
@vkbo