Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit clear index signal when project is closed #1720

Merged
merged 3 commits into from
Feb 29, 2024
Merged

Emit clear index signal when project is closed #1720

merged 3 commits into from
Feb 29, 2024

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Feb 29, 2024

Summary:

This PR adds a call to clear the index when a project is closed so a indexCleared signal is emitted. This clears the reference panel. The panel is anyway rebuilt when a new index is loaded, but only if there are any tags defined, which leaves data behind if the next project opened doesn't have any.

Related Issue(s):

Closes #1718

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.3 milestone Feb 29, 2024
@vkbo vkbo merged commit 750ba36 into main Feb 29, 2024
9 checks passed
@vkbo vkbo deleted the clear_ref_panel branch February 29, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Viewer Panel contents get carried over from one Project to another
1 participant