Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various issues on the Welcome dialog #1707

Merged
merged 7 commits into from
Feb 20, 2024
Merged

Fix various issues on the Welcome dialog #1707

merged 7 commits into from
Feb 20, 2024

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Feb 20, 2024

Summary:

This PR:

  • Hides unused controls on the Create New Project page when the option to populate from example project or copy project is selected.
  • Adds check that the target folder does not exist before extracting the sample project.
  • Drops the Language setting from the Create New Project form.
  • Replaces the QDialogButtonBox with a set of regular buttons, moves the Create New Project buttons to the same line, and adds a filter that will show/hide buttons depending on which page is active.

Related Issue(s):

Closes #1705
Closes #1706

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo merged commit 2fb87c4 into dev Feb 20, 2024
9 checks passed
@vkbo vkbo deleted the welcome_buttons branch February 20, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable irrelevant buttons in the New Project dialog Make inactive controls invisible in Welcome dialog
1 participant