Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing icons when using a custom icon theme #1780

Closed
HeyMyian opened this issue Mar 27, 2024 · 4 comments · Fixed by #1781
Closed

Missing icons when using a custom icon theme #1780

HeyMyian opened this issue Mar 27, 2024 · 4 comments · Fixed by #1781
Labels
enhancement Request: New feature or improvement user interface Component: General user interface

Comments

@HeyMyian
Copy link
Contributor

When using a custom icon theme, and new novelWriter versions add new icons, these icons will be missing from the UI until I manually copy the icons and their definitions to /AppData/Roaming or Linux equivalent. The same might be true for when updates introduce new definitions for UI colors or syntax highlighting colors. If that is the case, I've simply never noticed.

Ideally, missing icons and other definitions should fallback to either the light or dark standard theme as defined in the novelWriter core files. Is that possible?

@vkbo
Copy link
Owner

vkbo commented Mar 27, 2024

Not with the way it's currently set up, no. The theme settings correspond directly to the name of the theme file. Loading multiple themes is not supported at the moment.

novelWriter used to have fallback icons, but it was a real pain to maintain. Theme colours fall back to fixed colours. Icons fall back to a blank icon. I could make the missing icon a little more obvious by falling back to something more visible though. I can add a big red cross fallback icon.

@vkbo vkbo added this to the Release 2.4 RC 1 milestone Mar 27, 2024
@vkbo vkbo added enhancement Request: New feature or improvement user interface Component: General user interface labels Mar 27, 2024
@vkbo
Copy link
Owner

vkbo commented Mar 27, 2024

By the way, the documentation now lists when new syntax/theme colours were added, so it's possible to include them.

@vkbo
Copy link
Owner

vkbo commented Mar 27, 2024

I've added a very obvious (I hope) placeholder icon.

image

@vkbo
Copy link
Owner

vkbo commented Mar 27, 2024

Merged. I also cleaned up the styling of the new search tool a little.

@vkbo vkbo closed this as completed Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Request: New feature or improvement user interface Component: General user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants